Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1004623002: MIPS: Simplify pending message object handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 5311 matching lines...) Expand 10 before | Expand all | Expand 10 after
5322 5322
5323 // Store result register while executing finally block. 5323 // Store result register while executing finally block.
5324 __ push(a1); 5324 __ push(a1);
5325 5325
5326 // Store pending message while executing finally block. 5326 // Store pending message while executing finally block.
5327 ExternalReference pending_message_obj = 5327 ExternalReference pending_message_obj =
5328 ExternalReference::address_of_pending_message_obj(isolate()); 5328 ExternalReference::address_of_pending_message_obj(isolate());
5329 __ li(at, Operand(pending_message_obj)); 5329 __ li(at, Operand(pending_message_obj));
5330 __ lw(a1, MemOperand(at)); 5330 __ lw(a1, MemOperand(at));
5331 __ push(a1); 5331 __ push(a1);
5332
5333 ExternalReference has_pending_message =
5334 ExternalReference::address_of_has_pending_message(isolate());
5335 __ li(at, Operand(has_pending_message));
5336 __ lw(a1, MemOperand(at));
5337 __ SmiTag(a1);
5338 __ push(a1);
5339 } 5332 }
5340 5333
5341 5334
5342 void FullCodeGenerator::ExitFinallyBlock() { 5335 void FullCodeGenerator::ExitFinallyBlock() {
5343 DCHECK(!result_register().is(a1)); 5336 DCHECK(!result_register().is(a1));
5344 // Restore pending message from stack. 5337 // Restore pending message from stack.
5345 __ pop(a1); 5338 __ pop(a1);
5346 __ SmiUntag(a1);
5347 ExternalReference has_pending_message =
5348 ExternalReference::address_of_has_pending_message(isolate());
5349 __ li(at, Operand(has_pending_message));
5350 __ sw(a1, MemOperand(at));
5351
5352 __ pop(a1);
5353 ExternalReference pending_message_obj = 5339 ExternalReference pending_message_obj =
5354 ExternalReference::address_of_pending_message_obj(isolate()); 5340 ExternalReference::address_of_pending_message_obj(isolate());
5355 __ li(at, Operand(pending_message_obj)); 5341 __ li(at, Operand(pending_message_obj));
5356 __ sw(a1, MemOperand(at)); 5342 __ sw(a1, MemOperand(at));
5357 5343
5358 // Restore result register from stack. 5344 // Restore result register from stack.
5359 __ pop(a1); 5345 __ pop(a1);
5360 5346
5361 // Uncook return address and return. 5347 // Uncook return address and return.
5362 __ pop(result_register()); 5348 __ pop(result_register());
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
5470 Assembler::target_address_at(pc_immediate_load_address)) == 5456 Assembler::target_address_at(pc_immediate_load_address)) ==
5471 reinterpret_cast<uint32_t>( 5457 reinterpret_cast<uint32_t>(
5472 isolate->builtins()->OsrAfterStackCheck()->entry())); 5458 isolate->builtins()->OsrAfterStackCheck()->entry()));
5473 return OSR_AFTER_STACK_CHECK; 5459 return OSR_AFTER_STACK_CHECK;
5474 } 5460 }
5475 5461
5476 5462
5477 } } // namespace v8::internal 5463 } } // namespace v8::internal
5478 5464
5479 #endif // V8_TARGET_ARCH_MIPS 5465 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698