ppapi/shared_impl/resource.h - Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/resource.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/shared_impl/resource.h

diff --git a/ppapi/shared_impl/resource.h b/ppapi/shared_impl/resource.h

index 999ece30fd0e75cccbabd4255ce37a5942c60a93..28e4143a4ee0c445ee1fb55e3a35d15d5b0cc180 100644

--- a/ppapi/shared_impl/resource.h

+++ b/ppapi/shared_impl/resource.h

@@ -118,7 +118,8 @@ FOR_ALL_PPAPI_RESOURCE_APIS(DECLARE_RESOURCE_CLASS)

// cases.

enum ResourceObjectType { OBJECT_IS_IMPL, OBJECT_IS_PROXY };

-class PPAPI_SHARED_EXPORT Resource : public base::RefCounted<Resource> {

+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.

+class PPAPI_SHARED_EXPORT Resource : public base::UnsafeRefCounted<Resource> {

public:

// Constructor for impl and non-proxied, instance-only objects.

« base/memory/ref_counted.h ('K') | « net/disk_cache/blockfile/trace.h ('k') | sql/connection.h » ('j') | no next file with comments »