Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: net/disk_cache/blockfile/trace.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/blockfile/trace.h
diff --git a/net/disk_cache/blockfile/trace.h b/net/disk_cache/blockfile/trace.h
index 6805e6c60c27dedd06f69e8f4572afa3d5181669..48e370ca28d563c12e8980e90405fc19a75fe843 100644
--- a/net/disk_cache/blockfile/trace.h
+++ b/net/disk_cache/blockfile/trace.h
@@ -21,8 +21,10 @@ void DestroyTrace(void);
// Simple class to handle the trace buffer lifetime. Any object interested in
// tracing should keep a reference to the object returned by GetTraceObject().
-class TraceObject : public base::RefCounted<TraceObject> {
- friend class base::RefCounted<TraceObject>;
+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
+class TraceObject : public base::UnsafeRefCounted<TraceObject> {
+ friend class base::UnsafeRefCounted<TraceObject>;
+
public:
static TraceObject* GetTraceObject();
void EnableTracing(bool enable);

Powered by Google App Engine
This is Rietveld 408576698