Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: gpu/command_buffer/service/valuebuffer_manager.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/valuebuffer_manager.h
diff --git a/gpu/command_buffer/service/valuebuffer_manager.h b/gpu/command_buffer/service/valuebuffer_manager.h
index d67616a104b208048f5acc8ec53b3daaeea19b02..b05eab226c1c186a0d1a01ca13fb937834a73bf2 100644
--- a/gpu/command_buffer/service/valuebuffer_manager.h
+++ b/gpu/command_buffer/service/valuebuffer_manager.h
@@ -22,8 +22,9 @@ namespace gles2 {
class ValuebufferManager;
+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
class GPU_EXPORT SubscriptionRefSet
- : public base::RefCounted<SubscriptionRefSet> {
+ : public base::UnsafeRefCounted<SubscriptionRefSet> {
public:
class GPU_EXPORT Observer {
public:
@@ -42,7 +43,7 @@ class GPU_EXPORT SubscriptionRefSet
virtual ~SubscriptionRefSet();
private:
- friend class base::RefCounted<SubscriptionRefSet>;
+ friend class base::UnsafeRefCounted<SubscriptionRefSet>;
friend class ValuebufferManager;
typedef base::hash_map<unsigned int, int> RefSet;

Powered by Google App Engine
This is Rietveld 408576698