Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3509)

Unified Diff: gpu/command_buffer/service/shader_translator_cache.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/shader_translator_cache.h
diff --git a/gpu/command_buffer/service/shader_translator_cache.h b/gpu/command_buffer/service/shader_translator_cache.h
index 6b0b1a57ef35cfc3a727a8962db1af05803dbae3..ca7a5367b3f4118d1f49deb62b7cded65e5e402d 100644
--- a/gpu/command_buffer/service/shader_translator_cache.h
+++ b/gpu/command_buffer/service/shader_translator_cache.h
@@ -22,8 +22,9 @@ namespace gles2 {
//
// TODO(backer): Investigate using glReleaseShaderCompiler as an alternative to
// to this cache.
+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
class GPU_EXPORT ShaderTranslatorCache
- : public base::RefCounted<ShaderTranslatorCache>,
+ : public base::UnsafeRefCounted<ShaderTranslatorCache>,
public NON_EXPORTED_BASE(ShaderTranslator::DestructionObserver) {
public:
ShaderTranslatorCache();
@@ -40,7 +41,7 @@ class GPU_EXPORT ShaderTranslatorCache
ShCompileOptions driver_bug_workarounds);
private:
- friend class base::RefCounted<ShaderTranslatorCache>;
+ friend class base::UnsafeRefCounted<ShaderTranslatorCache>;
friend class ShaderTranslatorCacheTest_InitParamComparable_Test;
~ShaderTranslatorCache() override;

Powered by Google App Engine
This is Rietveld 408576698