Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: gpu/command_buffer/service/mailbox_manager.h

Issue 1004593005: base::RefCounted now DCHECKs when referenced from multiple threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lots of tests using UnsafeRefCounted. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/mailbox_manager.h
diff --git a/gpu/command_buffer/service/mailbox_manager.h b/gpu/command_buffer/service/mailbox_manager.h
index 8b53ce4c14da0a3074f173a6f28983d1116de46f..9f9a6b01db3fcd3a2ca9b0ed3bb25f1190631fd8 100644
--- a/gpu/command_buffer/service/mailbox_manager.h
+++ b/gpu/command_buffer/service/mailbox_manager.h
@@ -15,7 +15,9 @@ namespace gles2 {
class Texture;
// Manages resources scoped beyond the context or context group level.
-class GPU_EXPORT MailboxManager : public base::RefCounted<MailboxManager> {
+// TODO(mgiuca): Avoid using UnsafeRefCounted. http://crbug.com/469952.
+class GPU_EXPORT MailboxManager
+ : public base::UnsafeRefCounted<MailboxManager> {
public:
// Look up the texture definition from the named mailbox.
virtual Texture* ConsumeTexture(const Mailbox& mailbox) = 0;
@@ -38,7 +40,7 @@ class GPU_EXPORT MailboxManager : public base::RefCounted<MailboxManager> {
virtual ~MailboxManager() {}
private:
- friend class base::RefCounted<MailboxManager>;
+ friend class base::UnsafeRefCounted<MailboxManager>;
DISALLOW_COPY_AND_ASSIGN(MailboxManager);
};

Powered by Google App Engine
This is Rietveld 408576698