Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/corelib/for_in_test.dart

Issue 100443005: Remove obsolete TODOs from tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/hash_map_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/corelib/for_in_test.dart
===================================================================
--- tests/corelib/for_in_test.dart (revision 31056)
+++ tests/corelib/for_in_test.dart (working copy)
@@ -53,10 +53,9 @@
count += i;
}
Expect.equals(7, count);
- // TODO(ngeoffray): We should really test that [i] is 4 with a set
- // that preserves order. For now, making sure [i] is in the set
- // will have to do.
Expect.equals(true, set.contains(i));
+ // The default implementation of [Set] preserves order.
+ Expect.equals(4, i);
}
static void testBreak() {
« no previous file with comments | « no previous file | tests/corelib/hash_map_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698