Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: tests/corelib/for_in_test.dart

Issue 100443005: Remove obsolete TODOs from tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/corelib/hash_map_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import "package:expect/expect.dart"; 5 import "package:expect/expect.dart";
6 6
7 class ForInTest { 7 class ForInTest {
8 static testMain() { 8 static testMain() {
9 testSimple(); 9 testSimple();
10 testBreak(); 10 testBreak();
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 } 46 }
47 Expect.equals(7, count); 47 Expect.equals(7, count);
48 48
49 count = 0; 49 count = 0;
50 int i = 0; 50 int i = 0;
51 Expect.equals(false, set.contains(i)); // Used to test [i] after loop. 51 Expect.equals(false, set.contains(i)); // Used to test [i] after loop.
52 for (i in set) { 52 for (i in set) {
53 count += i; 53 count += i;
54 } 54 }
55 Expect.equals(7, count); 55 Expect.equals(7, count);
56 // TODO(ngeoffray): We should really test that [i] is 4 with a set
57 // that preserves order. For now, making sure [i] is in the set
58 // will have to do.
59 Expect.equals(true, set.contains(i)); 56 Expect.equals(true, set.contains(i));
57 // The default implementation of [Set] preserves order.
58 Expect.equals(4, i);
60 } 59 }
61 60
62 static void testBreak() { 61 static void testBreak() {
63 Set<int> set = getSmallSet(); 62 Set<int> set = getSmallSet();
64 int count = 0; 63 int count = 0;
65 for (final i in set) { 64 for (final i in set) {
66 if (i == 4) break; 65 if (i == 4) break;
67 count += i; 66 count += i;
68 } 67 }
69 Expect.equals(true, count < 4); 68 Expect.equals(true, count < 4);
(...skipping 18 matching lines...) Expand all
88 } 87 }
89 88
90 Expect.equals(index, set.length); 89 Expect.equals(index, set.length);
91 Expect.equals(7, closures[0]() + closures[1]() + closures[2]()); 90 Expect.equals(7, closures[0]() + closures[1]() + closures[2]());
92 } 91 }
93 } 92 }
94 93
95 main() { 94 main() {
96 ForInTest.testMain(); 95 ForInTest.testMain();
97 } 96 }
OLDNEW
« no previous file with comments | « no previous file | tests/corelib/hash_map_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698