Issue 100433004: Sync Document.createProcessingInstruction() with spec

Issue 100433004: Sync Document.createProcessingInstruction() with spec (Closed)

Created:
7 years ago by philipj_slow

Modified:
7 years ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Sync Document.createProcessingInstruction() with spec http://dom.spec.whatwg.org/#dom-document-createprocessinginstruction Firefox Nightly already passes the added tests, so we would not be the first to adopt these changes. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163335

Patch Set 3 : test createProcessingInstruction for HTML doc #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -95 lines)			Patch
M	LayoutTests/dom/html/level1/core/documentinvalidcharacterexceptioncreatepi.js	View	1	1 chunk	+16 lines, -43 lines	0 comments	Download
M	LayoutTests/dom/html/level1/core/documentinvalidcharacterexceptioncreatepi1.js	View	1	1 chunk	+16 lines, -43 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/createProcessingInstruction-invalid-data.html	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/createProcessingInstruction-invalid-data-expected.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/createProcessingInstruction-invalid-target.html	View		1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Document/createProcessingInstruction-invalid-target-expected.txt	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Node/initial-values-expected.txt	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/Node/script-tests/initial-values.js	View	1 2	2 chunks	+13 lines, -4 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://codereview.chromium.org/100433004/diff/20001/LayoutTests/fast/dom/Node/script-tests/initial-values.js File LayoutTests/fast/dom/Node/script-tests/initial-values.js (left): https://codereview.chromium.org/100433004/diff/20001/LayoutTests/fast/dom/Node/script-tests/initial-values.js#oldcode161 LayoutTests/fast/dom/Node/script-tests/initial-values.js:161: shouldThrow("document.createProcessingInstruction('xml-stylesheet', 'type=\"text/xsl\" href=\"missing.xsl\"')"); so the following few lines should ...

7 years ago (2013-12-05 11:12:09 UTC) #2

philipj_slow

7 years ago (2013-12-05 11:57:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100433004/40001

7 years ago (2013-12-06 09:45:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100433004/40001

7 years ago (2013-12-06 12:35:45 UTC) #6

Message was sent while issue was closed.

Change committed as 163335

Expand Messages | Collapse Messages