Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 100433004: Sync Document.createProcessingInstruction() with spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test createProcessingInstruction for HTML doc Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/dom/Node/script-tests/initial-values.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 769 matching lines...) Expand 10 before | Expand all | Expand 10 after
780 { 780 {
781 return Comment::create(*this, data); 781 return Comment::create(*this, data);
782 } 782 }
783 783
784 PassRefPtr<CDATASection> Document::createCDATASection(const String& data, Except ionState& exceptionState) 784 PassRefPtr<CDATASection> Document::createCDATASection(const String& data, Except ionState& exceptionState)
785 { 785 {
786 if (isHTMLDocument()) { 786 if (isHTMLDocument()) {
787 exceptionState.throwUninformativeAndGenericDOMException(NotSupportedErro r); 787 exceptionState.throwUninformativeAndGenericDOMException(NotSupportedErro r);
788 return 0; 788 return 0;
789 } 789 }
790 if (data.find("]]>") != WTF::kNotFound) { 790 if (data.contains("]]>")) {
791 exceptionState.throwDOMException(InvalidCharacterError, "String cannot c ontain ']]>' since that is the end delimiter of a CData section."); 791 exceptionState.throwDOMException(InvalidCharacterError, "String cannot c ontain ']]>' since that is the end delimiter of a CData section.");
792 return 0; 792 return 0;
793 } 793 }
794 return CDATASection::create(*this, data); 794 return CDATASection::create(*this, data);
795 } 795 }
796 796
797 PassRefPtr<ProcessingInstruction> Document::createProcessingInstruction(const St ring& target, const String& data, ExceptionState& exceptionState) 797 PassRefPtr<ProcessingInstruction> Document::createProcessingInstruction(const St ring& target, const String& data, ExceptionState& exceptionState)
798 { 798 {
799 if (!isValidName(target)) { 799 if (!isValidName(target)) {
800 exceptionState.throwUninformativeAndGenericDOMException(InvalidCharacter Error); 800 exceptionState.throwDOMException(InvalidCharacterError, "The target prov ided ('" + target + "') is not a valid name.");
801 return 0; 801 return 0;
802 } 802 }
803 if (isHTMLDocument()) { 803 if (data.contains("?>")) {
804 exceptionState.throwUninformativeAndGenericDOMException(NotSupportedErro r); 804 exceptionState.throwDOMException(InvalidCharacterError, "The data provid ed ('" + data + "') contains '?>'.");
805 return 0; 805 return 0;
806 } 806 }
807 return ProcessingInstruction::create(*this, target, data); 807 return ProcessingInstruction::create(*this, target, data);
808 } 808 }
809 809
810 PassRefPtr<Text> Document::createEditingTextNode(const String& text) 810 PassRefPtr<Text> Document::createEditingTextNode(const String& text)
811 { 811 {
812 return Text::createEditingText(*this, text); 812 return Text::createEditingText(*this, text);
813 } 813 }
814 814
(...skipping 4416 matching lines...) Expand 10 before | Expand all | Expand 10 after
5231 } 5231 }
5232 5232
5233 FastTextAutosizer* Document::fastTextAutosizer() 5233 FastTextAutosizer* Document::fastTextAutosizer()
5234 { 5234 {
5235 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d()) 5235 if (!m_fastTextAutosizer && RuntimeEnabledFeatures::fastTextAutosizingEnable d())
5236 m_fastTextAutosizer = FastTextAutosizer::create(this); 5236 m_fastTextAutosizer = FastTextAutosizer::create(this);
5237 return m_fastTextAutosizer.get(); 5237 return m_fastTextAutosizer.get();
5238 } 5238 }
5239 5239
5240 } // namespace WebCore 5240 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/Node/script-tests/initial-values.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698