Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1004113003: Clarify arm gn configuration (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clarify arm gn configuration R=dpranke@chromium.org TBR=machenbach@chromium.org BUG= LOG=n Committed: https://crrev.com/788d9d1ba9994c1b74a1b93b4376acbbb04da617 Cr-Commit-Position: refs/heads/master@{#27209}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M BUILD.gn View 2 chunks +3 lines, -4 lines 2 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-13 07:39:24 UTC) #1
jochen (gone - plz use gerrit)
ptal https://codereview.chromium.org/1004113003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1004113003/diff/1/BUILD.gn#newcode140 BUILD.gn:140: # These defines ares used for the ARM ...
5 years, 9 months ago (2015-03-13 07:42:51 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1004113003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1004113003/diff/1/BUILD.gn#newcode140 BUILD.gn:140: # These defines ares used for the ARM ...
5 years, 9 months ago (2015-03-13 20:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004113003/1
5 years, 9 months ago (2015-03-16 09:23:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-16 09:23:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004113003/1
5 years, 9 months ago (2015-03-16 09:24:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 09:54:50 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 09:55:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/788d9d1ba9994c1b74a1b93b4376acbbb04da617
Cr-Commit-Position: refs/heads/master@{#27209}

Powered by Google App Engine
This is Rietveld 408576698