Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: BUILD.gn

Issue 1004113003: Clarify arm gn configuration (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 827cd2c366bbdf2a7c4d3cf8792a78b102b7ee2c..f1854afa9209cdb76c12a49af2aac860ea5ba156 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -124,14 +124,12 @@ config("toolchain") {
}
if (arm_fpu == "vfpv3-d16") {
defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ]
- }
- if (arm_fpu == "vfpv3") {
+ } else if (arm_fpu == "vfpv3") {
defines += [
"CAN_USE_VFP3_INSTRUCTIONS",
"CAN_USE_VFP32DREGS",
]
- }
- if (arm_fpu == "neon") {
+ } else if (arm_fpu == "neon") {
defines += [
"CAN_USE_VFP3_INSTRUCTIONS",
"CAN_USE_VFP32DREGS",
@@ -139,6 +137,7 @@ config("toolchain") {
]
}
} else {
+ # These defines ares used for the ARM simulator.
jochen (gone - plz use gerrit) 2015/03/13 07:42:51 it's not just for the snapshot toolchain - we coul
Dirk Pranke 2015/03/13 20:47:17 Um, okay ... I guess I don't understand what this
defines += [
"CAN_USE_ARMV7_INSTRUCTIONS",
"CAN_USE_VFP3_INSTRUCTIONS",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698