Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 10041014: IndexedDB: API rename to allow return type of keyPath accessors to change (Closed)

Created:
8 years, 8 months ago by jsbell
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

IndexedDB: API rename to allow return type of keyPath accessors to change To introduce a real KeyPath type, the return type of keyPath accessors needs to change from a String to an IDBKeyPath. To do this requires temporarily moving the methods aside. The WebKit API change (which must land first) is at: https://bugs.webkit.org/show_bug.cgi?id=84208 R=darin@chromium.org,dgrogan@chromium.org BUG=112308 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133500

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unneeded includes, added TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/idb_bindings.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
Please take a look. Needs to wait on https://bugs.webkit.org/show_bug.cgi?id=84208 before landing.
8 years, 8 months ago (2012-04-17 23:50:16 UTC) #1
dgrogan
LGTM https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode53 content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: using WebKit::WebString; Looks like you don't (yet?) need ...
8 years, 8 months ago (2012-04-18 01:56:35 UTC) #2
jsbell
On 2012/04/18 01:56:35, dgrogan wrote: https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc > File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): > > https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode53 > content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: ...
8 years, 8 months ago (2012-04-18 17:00:44 UTC) #3
jsbell
WebKit r114708 has been rolled in, so this can land now. darin@, OWNERS review of ...
8 years, 8 months ago (2012-04-20 17:03:26 UTC) #4
darin (slow to review)
OK, LGTM
8 years, 8 months ago (2012-04-23 16:54:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10041014/5002
8 years, 8 months ago (2012-04-23 17:06:07 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:47:12 UTC) #7
Change committed as 133500

Powered by Google App Engine
This is Rietveld 408576698