IndexedDB: API rename to allow return type of keyPath accessors to change

IndexedDB: API rename to allow return type of keyPath accessors to change

To introduce a real KeyPath type, the return type of keyPath accessors 
needs to change from a String to an IDBKeyPath. To do this requires 
temporarily moving the methods aside. The WebKit API change (which must
land first) is at: https://bugs.webkit.org/show_bug.cgi?id=84208

R=darin@chromium.org,dgrogan@chromium.org
BUG=112308
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133500

[jsbell, 2012-04-17 23:50:16]

Please take a look. Needs to wait on
https://bugs.webkit.org/show_bug.cgi?id=84208 before landing.

[dgrogan, 2012-04-18 01:56:35]

LGTM

https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_pro...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_pro...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: using
WebKit::WebString;
Looks like you don't (yet?) need these WebString lines?

https://chromiumcodereview.appspot.com/10041014/diff/1/webkit/glue/idb_bindin...
File webkit/glue/idb_bindings.cc (right):

https://chromiumcodereview.appspot.com/10041014/diff/1/webkit/glue/idb_bindin...
webkit/glue/idb_bindings.cc:28: WebIDBKeyPath::create(WebString(idb_key_path));
You're going to change WebIDBKeyPath's parameter type in a future patch?  Or you
don't want to rely on the chrome-specific WebString(const string16& s) ctor?

[jsbell, 2012-04-18 17:00:44]

On 2012/04/18 01:56:35, dgrogan wrote:
https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_pro...
> File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10041014/diff/1/content/browser/in_pro...
> content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:53: using
> WebKit::WebString;
> Looks like you don't (yet?) need these WebString lines?

Correct; removed.
 
>
https://chromiumcodereview.appspot.com/10041014/diff/1/webkit/glue/idb_bindin...
> File webkit/glue/idb_bindings.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10041014/diff/1/webkit/glue/idb_bindin...
> webkit/glue/idb_bindings.cc:28:
WebIDBKeyPath::create(WebString(idb_key_path));
> You're going to change WebIDBKeyPath's parameter type in a future patch?  Or
you
> don't want to rely on the chrome-specific WebString(const string16& s) ctor?

A later patch on the WK side adds WebIDBKeyPath::create(WebVector<WebString>)
and the string16 conversion is ambiguous. I'll add a TODO.

[jsbell, 2012-04-20 17:03:26]

WebKit r114708 has been rolled in, so this can land now.

darin@, OWNERS review of webkit/glue ?

[darin (slow to review), 2012-04-23 16:54:33]

OK, LGTM

[commit-bot: I haz the power, 2012-04-23 17:06:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/10041014/5002

[commit-bot: I haz the power, 2012-04-23 19:47:12]

Change committed as 133500