[Extensions] Add logic for when to show the toolbar redesign bubble.

[Extensions] Add logic for when to show the toolbar redesign bubble.

Show the toolbar redesign bubble once per 24 hour period when the mouse
enters the toolbar, if and only if the user has not acknowledged it previously
and there is something new in the toolbar (i.e., and extension that was not
there previously).

BUG=461039
Committed: https://crrev.com/28582da8c1b67cf19227bc3276c040c586756eb0
Cr-Commit-Position: refs/heads/master@{#321383}

[Devlin, 2015-03-13 04:49:47]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-03-13 04:49:48]

Now we've got a bit of logic on when to show the bubble. Take a look when you
can. :)

[Finnur, 2015-03-13 10:54:53]

LGTM. One minor comment.

https://codereview.chromium.org/1004063003/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1004063003/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:871:
prefs::kToolbarIconSurfacingBubbleAcknowledged, true);
Once you set this to true, there's no longer a need to carry around the last
shown time pref, right? We should probably delete it.

Note: You set this to true in two places so you'd want to refactor this into a
small helper function and call it here and on line 690.

[Devlin, 2015-03-13 16:33:29]

https://codereview.chromium.org/1004063003/diff/1/chrome/browser/ui/toolbar/t...
File chrome/browser/ui/toolbar/toolbar_actions_bar.cc (right):

https://codereview.chromium.org/1004063003/diff/1/chrome/browser/ui/toolbar/t...
chrome/browser/ui/toolbar/toolbar_actions_bar.cc:871:
prefs::kToolbarIconSurfacingBubbleAcknowledged, true);
On 2015/03/13 10:54:53, Finnur wrote:
> Once you set this to true, there's no longer a need to carry around the last
> shown time pref, right? We should probably delete it.
> 
> Note: You set this to true in two places so you'd want to refactor this into a
> small helper function and call it here and on line 690.

Good call; we can definitely clear the pref.

I don't think we need the helper function, since we can just call
OnToolbarActionsBarBubbleClosed() from ShouldShowInfoBubble(), but lemme know if
you think this is confusing. :)

[Devlin, 2015-03-13 16:33:41]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2015-03-13 16:33:42]

+Avi for the little bit of cocoa

[Devlin, 2015-03-16 22:16:49]

On 2015/03/13 16:33:42, Devlin wrote:
> +Avi for the little bit of cocoa

Avi, friendly ping. :)

[Avi (use Gerrit), 2015-03-18 20:27:04]

cocoa lgtm

[Devlin, 2015-03-18 22:43:38]

Patchset #4 (id:60001) has been deleted

[Devlin, 2015-03-19 00:01:28]

rdevlin.cronin@chromium.org changed reviewers:
+ battre@chromium.org

[Devlin, 2015-03-19 00:01:29]

+battre@ for browser_prefs.cc

[battre, 2015-03-19 09:28:45]

browser_prefs.cc LGTM with two comments.

https://codereview.chromium.org/1004063003/diff/80001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1004063003/diff/80001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:406: // 
ToolbarActionsBar::RegisterPrefs(prefs);
indenting / should this be commented out?

https://codereview.chromium.org/1004063003/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1004063003/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:1233: extern const char
kToolbarIconSurfacingBubbleLastShowTime[] =
extern?

[Devlin, 2015-03-19 16:28:09]

https://codereview.chromium.org/1004063003/diff/80001/chrome/browser/ui/toolb...
File chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc (right):

https://codereview.chromium.org/1004063003/diff/80001/chrome/browser/ui/toolb...
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc:406: // 
ToolbarActionsBar::RegisterPrefs(prefs);
On 2015/03/19 09:28:45, battre wrote:
> indenting / should this be commented out?

Done.

https://codereview.chromium.org/1004063003/diff/80001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1004063003/diff/80001/chrome/common/pref_name...
chrome/common/pref_names.cc:1233: extern const char
kToolbarIconSurfacingBubbleLastShowTime[] =
On 2015/03/19 09:28:45, battre wrote:
> extern?

Whoops! Copy-paste error.  Looks like I wasn't the only one - fixed the others,
too :)

[Devlin, 2015-03-19 16:28:12]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-19 16:28:12]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org,
avi@chromium.org, battre@chromium.org
Link to the patchset: https://codereview.chromium.org/1004063003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-03-19 16:28:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004063003/100001

[commit-bot: I haz the power, 2015-03-19 17:18:57]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-03-19 17:19:38]

Patchset 5 (id:??) landed as
https://crrev.com/28582da8c1b67cf19227bc3276c040c586756eb0
Cr-Commit-Position: refs/heads/master@{#321383}