chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm - Issue 1004063003: [Extensions] Add logic for when to show the toolbar redesign bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm

Issue 1004063003: [Extensions] Add logic for when to show the toolbar redesign bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac.mm ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm

index 5d714e6a4c77d4d1cdbc3ad33c5c9ff8b0286037..4cbffb553e2154e62b79a8fe607ab1d9cf2ed796 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_toolbar_icon_surfacing_bubble_mac_unittest.mm

@@ -21,6 +21,7 @@ class TestDelegate : public ToolbarActionsBarBubbleDelegate {

TestDelegate() {}

~TestDelegate() {}

+ void OnToolbarActionsBarBubbleShown() override {}

void OnToolbarActionsBarBubbleClosed(CloseAction action) override {

EXPECT_FALSE(action_);

action_.reset(new CloseAction(action));