Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Introduces MessageReceiverWithStatus and MessageReceiverWithResponderStatus. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
index afc6504dc81f33bf535546964eafcd06a29d266b..37f9e070ab3f5cf36a9a8485cd8fef84d0925df0 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl
@@ -1,13 +1,14 @@
-class {{interface.name}}Stub : public mojo::MessageReceiverWithResponder {
+class {{interface.name}}Stub : public mojo::MessageReceiverWithResponderStatus {
public:
{{interface.name}}Stub();
+ ~{{interface.name}}Stub() override;
void set_sink({{interface.name}}* sink) { sink_ = sink; }
{{interface.name}}* sink() { return sink_; }
virtual bool Accept(mojo::Message* message) override;
virtual bool AcceptWithResponder(mojo::Message* message,
- mojo::MessageReceiver* responder) override;
-
+ mojo::MessageReceiverWithStatus* responder) override;
jamesr 2015/03/23 18:16:33 nit: since you're here (hah!) generating both 'vir
rudominer 2015/03/30 21:00:50 Done.
+
private:
{{interface.name}}* sink_;
};

Powered by Google App Engine
This is Rietveld 408576698