mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl - Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_stub_declaration.tmpl

Issue 1003773002: CPP bindings: DCHECK when a Callback is destructed without being invoked (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Introduces MessageReceiverWithStatus and MessageReceiverWithResponderStatus. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 class {{interface.name}}Stub : public mojo::MessageReceiverWithResponder {	1 class {{interface.name}}Stub : public mojo::MessageReceiverWithResponderStatus {

2 public:	2 public:

3 {{interface.name}}Stub();	3 {{interface.name}}Stub();

	4 ~{{interface.name}}Stub() override;

4 void set_sink({{interface.name}}* sink) { sink_ = sink; }	5 void set_sink({{interface.name}}* sink) { sink_ = sink; }

5 {{interface.name}}* sink() { return sink_; }	6 {{interface.name}}* sink() { return sink_; }

6	7

7 virtual bool Accept(mojo::Message* message) override;	8 virtual bool Accept(mojo::Message* message) override;

8 virtual bool AcceptWithResponder(mojo::Message* message,	9 virtual bool AcceptWithResponder(mojo::Message* message,

9 mojo::MessageReceiver* responder) override;	10 mojo::MessageReceiverWithStatus* responder) override;
	jamesr 2015/03/23 18:16:33 nit: since you're here (hah!) generating both 'vir nit: since you're here (hah!) generating both 'virtual' and 'override' is unnecessary, this should generate only the 'override' keyword rudominer 2015/03/30 21:00:50 Done. Show quoted text On 2015/03/23 18:16:33, jamesr wrote: > nit: since you're here (hah!) generating both 'virtual' and 'override' is > unnecessary, this should generate only the 'override' keyword Done.
10	11

11 private:	12 private:

12 {{interface.name}}* sink_;	13 {{interface.name}}* sink_;

13 };	14 };

OLD	NEW