Issue 100333004: Fix crash when using touch selection in immersive fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100333004: Fix crash when using touch selection in immersive fullscreen (Closed)

Created:
7 years ago by pkotwicz

Modified:
7 years ago

Reviewers:
James Cook, mohsen

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash when using touch selection in immersive fullscreen. The ImmersiveFullscreenController was incorrectly consuming all ET_GESTURE_SCROLL_BEGIN. This resulted in TouchSelectionControllerImpl::EditingHandleView getting ET_GESTURE_SCROLL_UPDATE but not ET_GESTURE_SCROLL_BEGIN. This CL also makes the touch selection handles hide when a user uses a gesture to hide the top-of-window views. BUG=324607 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239030

Patch Set 1 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
	M	ash/wm/immersive_fullscreen_controller.cc	View		3 chunks	+10 lines, -2 lines	0 comments	Download
	M	ash/wm/immersive_fullscreen_controller_unittest.cc	View		3 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Varun, can you please take a look? I am mostly interested in whether you suspect ...

7 years ago (2013-12-04 04:46:45 UTC) #1

mohsen

On 2013/12/05 00:53:26, pkotwicz wrote: > Mohsen, can you please take a look? LGTM regarding ...

7 years ago (2013-12-05 16:45:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/100333004/20001

7 years ago (2013-12-05 17:26:02 UTC) #6

Message was sent while issue was closed.

Change committed as 239030

Expand Messages | Collapse Messages