Fix crash when using touch selection in immersive fullscreen

ash/wm/immersive_fullscreen_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/immersive_fullscreen_controller.h"
 
 #include <set>
 
 #include "ash/shell.h"
 #include "ash/wm/window_state.h"
@@ skipping 271 matching lines @@
     located_event_revealed_lock_.reset();
     focus_revealed_lock_.reset();
 
     // Try doing the animation.
     MaybeEndReveal(ANIMATE_SLOW);
 
     if (reveal_state_ == REVEALED) {
       // Reveal was unsuccessful. Reacquire the revealed locks if appropriate.
       UpdateLocatedEventRevealedLock(NULL);
       UpdateFocusRevealedLock();
+    } else {
+      // Clearing focus is important because it closes focus-related popups like
+      // the touch selection handles.
+      widget_->GetFocusManager()->ClearFocus();
     }
   } else {
     // Stop cursor-at-top tracking.
     top_edge_hover_timer_.Stop();
     reveal_state_ = CLOSED;
 
     delegate_->OnImmersiveFullscreenExited();
   }
 }
 
@@ skipping 78 matching lines @@
 
   // Touch gestures should not initiate revealing the top-of-window views while
   // |widget_| is inactive.
   if (!widget_->IsActive())
     return;
 
   switch (event->type()) {
     case ui::ET_GESTURE_SCROLL_BEGIN:
       if (ShouldHandleGestureEvent(GetEventLocationInScreen(*event))) {
         gesture_begun_ = true;
-        event->SetHandled();
+        // Do not consume the event. Otherwise, we end up consuming all
+        // ui::ET_GESTURE_SCROLL_BEGIN events in the top-of-window views
+        // when the top-of-window views are revealed.
       }
       break;
     case ui::ET_GESTURE_SCROLL_UPDATE:
       if (gesture_begun_) {
         if (UpdateRevealedLocksForSwipe(GetSwipeType(event)))
           event->SetHandled();
         gesture_begun_ = false;
       }
       break;
     case ui::ET_GESTURE_SCROLL_END:
@@ skipping 321 matching lines @@
       located_event_revealed_lock_.reset(GetRevealedLock(ANIMATE_REVEAL_YES));
       return true;
     }
   } else {
     if (swipe_type == SWIPE_CLOSE) {
       // Attempt to end the reveal. If other code is holding onto a lock, the
       // attempt will be unsuccessful.
       located_event_revealed_lock_.reset();
       focus_revealed_lock_.reset();
 
-      if (reveal_state_ == SLIDING_CLOSED || reveal_state_ == CLOSED)
+      if (reveal_state_ == SLIDING_CLOSED || reveal_state_ == CLOSED) {
+        widget_->GetFocusManager()->ClearFocus();
         return true;
+      }
 
       // Ending the reveal was unsuccessful. Reaquire the locks if appropriate.
       UpdateLocatedEventRevealedLock(NULL);
       UpdateFocusRevealedLock();
     }
   }
   return false;
 }
 
 int ImmersiveFullscreenController::GetAnimationDuration(Animate animate) const {
@@ skipping 162 matching lines @@
         AsBubbleDelegate(transient_child);
     if (bubble_delegate &&
         bubble_delegate->GetAnchorView() &&
         top_container_->Contains(bubble_delegate->GetAnchorView())) {
       bubble_manager_->StartObserving(transient_child);
     }
   }
 }
 
 }  // namespace ash