Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1003273004: [RenderText] Added chrome os exclusion from doesntClip test (Closed)

Created:
5 years, 9 months ago by dschuyler
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, groby-ooo-7-16, Justin Donnelly
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[RenderText] Added chrome os exclusion from doesntClip test. The GetStringSize has had some unfound errors that are now being found by an improvement to the unit test. There is another bug (465583) that is intended to look into these standing issues. For the short term, this CL will remove Chrome OS from the failing unit test (which is no worst than the situation prior to the unit test being improved). BUG=468903 Committed: https://crrev.com/294db37df3285042a677d49c3b4040250d0c5c97 Cr-Commit-Position: refs/heads/master@{#321590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/gfx/render_text_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dschuyler
5 years, 9 months ago (2015-03-19 20:58:20 UTC) #2
sadrul
msw@ is render-text owner
5 years, 9 months ago (2015-03-20 04:02:37 UTC) #4
msw
shrug, lgtm
5 years, 9 months ago (2015-03-20 16:40:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003273004/1
5 years, 9 months ago (2015-03-20 17:11:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 17:35:01 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:36:17 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/294db37df3285042a677d49c3b4040250d0c5c97
Cr-Commit-Position: refs/heads/master@{#321590}

Powered by Google App Engine
This is Rietveld 408576698