Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 1003263002: DevTools: support scopes and iframes when debugging service workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index 1ce2bb65cbc7c93b89bca2f723f682972498cc30..36e1a5afff1175818dd310a26ce541b285dc9bfe 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -21,9 +21,10 @@
namespace content {
-class RenderFrameHost;
+class RenderFrameHostImpl;
class ServiceWorkerContextWrapper;
class ServiceWorkerDevToolsAgentHost;
+class WebContents;
namespace devtools {
namespace service_worker {
@@ -36,9 +37,9 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
ServiceWorkerHandler();
~ServiceWorkerHandler() override;
- void SetRenderFrameHost(RenderFrameHost* render_frame_host);
+ void SetRenderFrameHost(RenderFrameHostImpl* render_frame_host);
void SetClient(scoped_ptr<Client> client);
- void SetURL(const GURL& url);
+ void UpdateURLs();
void Detached();
// Protocol 'service worker' domain implementation.
@@ -62,7 +63,7 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void AgentHostClosed(DevToolsAgentHost* agent_host,
bool replaced_with_another_client) override;
- void ReportWorkerCreated(DevToolsAgentHost* host, bool new_worker);
+ void ReportWorkerCreated(ServiceWorkerDevToolsAgentHost* host);
bool MatchesInspectedPage(ServiceWorkerDevToolsAgentHost* host);
@@ -78,8 +79,9 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
std::string, scoped_refptr<ServiceWorkerDevToolsAgentHost>>;
AttachedHosts attached_hosts_;
bool enabled_;
- GURL url_;
+ std::set<GURL> urls_;
scoped_refptr<ContextObserver> context_observer_;
+ RenderFrameHostImpl* render_frame_host_;
base::WeakPtrFactory<ServiceWorkerHandler> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698