[DevTools] Handle emulation in embedder, call into web API.

[DevTools] Handle emulation in embedder, call into web API.

BUG=466598
Committed: https://crrev.com/9260b0a1dab5a8277a94a7393f002987f44322d8
Cr-Commit-Position: refs/heads/master@{#320722}

[dgozman, 2015-03-13 10:19:39]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-03-13 10:19:40]

Take a look please.

[pfeldman, 2015-03-13 13:00:17]

lgtm

https://codereview.chromium.org/1003113003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/page_handler.cc (right):

https://codereview.chromium.org/1003113003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/page_handler.cc:352:
!web_contents->GetVisibleURL().SchemeIs(kChromeDevToolsScheme) &&
DEBUG_DEVTOOLS ?

[dgozman, 2015-03-13 15:57:26]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, tsepez@chromium.org

[dgozman, 2015-03-13 15:57:27]

Please take a look.

@tsepez: please review view_messages.h. This patch adds two messages to switch
from renderer-initiated DevTools emulation (via blink API client call) to
browser-initiated one via IPC messages issued by PageHandler class. No
functionality change here.

@jochen: please review content/renderer.

https://codereview.chromium.org/1003113003/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/page_handler.cc (right):

https://codereview.chromium.org/1003113003/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/page_handler.cc:352:
!web_contents->GetVisibleURL().SchemeIs(kChromeDevToolsScheme) &&
On 2015/03/13 13:00:17, pfeldman wrote:
> DEBUG_DEVTOOLS ?

Done.

[Tom Sepez, 2015-03-13 16:28:23]

Messages LGTM.

[dgozman, 2015-03-16 05:39:58]

@jochen: please take a look at content/renderer.

[jochen (gone - plz use gerrit), 2015-03-16 10:06:43]

lgtm

[dgozman, 2015-03-16 10:08:46]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-03-16 10:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1003113003/#ps40001
(title: "extra include, DEBUG_DEVTOOLS define")

[commit-bot: I haz the power, 2015-03-16 10:09:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003113003/40001

[commit-bot: I haz the power, 2015-03-16 10:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-16 10:43:09]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[dgozman, 2015-03-16 12:47:33]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-03-16 12:47:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jochen@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1003113003/#ps60001
(title: "Fix tests and mac popups compilation")

[commit-bot: I haz the power, 2015-03-16 12:47:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003113003/60001

[commit-bot: I haz the power, 2015-03-16 13:45:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-16 13:46:12]

Patchset 4 (id:??) landed as
https://crrev.com/9260b0a1dab5a8277a94a7393f002987f44322d8
Cr-Commit-Position: refs/heads/master@{#320722}