content/renderer/render_view_impl.h - Issue 1003113003: [DevTools] Handle emulation in embedder, call into web API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 1003113003: [DevTools] Handle emulation in embedder, call into web API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests and mac popups compilation Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 8496410534f581ab43826c6adba418952fbade5b..f867c3b553c548932630556c1e2bce90fe22fe36 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -509,9 +509,9 @@ class CONTENT_EXPORT RenderViewImpl

void Initialize(const ViewMsg_New_Params& params,

CompositorDependencies* compositor_deps,

bool was_created_by_renderer);

- void SetScreenMetricsEmulationParameters(float device_scale_factor,

- const gfx::Point& root_layer_offset,

- float root_layer_scale) override;

+ void SetScreenMetricsEmulationParameters(

+ bool enabled,

+ const blink::WebDeviceEmulationParams& params) override;

// Do not delete directly. This class is reference counted.

virtual ~RenderViewImpl();

@@ -551,6 +551,7 @@ class CONTENT_EXPORT RenderViewImpl

FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,

GetCompositionCharacterBoundsTest);

FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, OnNavigationHttpPost);

+ FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest, ScreenMetricsEmulation);

FRIEND_TEST_ALL_PREFIXES(RenderViewImplTest,

DecideNavigationPolicyHandlesAllTopLevel);

#if defined(OS_MACOSX)

« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »