Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1003113002: Allow GCScheduledForTesting ThreadState transition while sweeping-idle. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow GCScheduledForTesting ThreadState transition while sweeping-idle. Add missing case for transitioning to GCScheduledForTesting while in the SweepingAndIdleGCScheduled state. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. A speculative/blind fix for https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/5438/layout-test-results/fast/forms/change-form-element-document-crash-crash-log.txt i.e., not been able to reproduce ...
5 years, 9 months ago (2015-03-13 08:33:53 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-13 08:59:24 UTC) #3
haraken
Thanks for spending tons of time for stabilization!
5 years, 9 months ago (2015-03-13 08:59:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003113002/1
5 years, 9 months ago (2015-03-13 09:49:24 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 09:52:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191827

Powered by Google App Engine
This is Rietveld 408576698