Source/platform/heap/ThreadState.cpp - Issue 1003113002: Allow GCScheduledForTesting ThreadState transition while sweeping-idle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1003113002: Allow GCScheduledForTesting ThreadState transition while sweeping-idle. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index 43f1fa03574b0c20a6556f65471640d80d9345bd..78dbd72ebbbb69142a7e5922dbb6e00826598b5b 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -638,7 +638,7 @@ void ThreadState::setGCState(GCState gcState)

case PreciseGCScheduled:

case GCScheduledForTesting:

checkThread();

- RELEASE_ASSERT(m_gcState == NoGCScheduled || m_gcState == IdleGCScheduled || m_gcState == PreciseGCScheduled || m_gcState == GCScheduledForTesting || m_gcState == StoppingOtherThreads || m_gcState == SweepingAndPreciseGCScheduled);

+ RELEASE_ASSERT(m_gcState == NoGCScheduled || m_gcState == IdleGCScheduled || m_gcState == PreciseGCScheduled || m_gcState == GCScheduledForTesting || m_gcState == StoppingOtherThreads || m_gcState == SweepingAndIdleGCScheduled || m_gcState == SweepingAndPreciseGCScheduled);

completeSweep();

break;

case StoppingOtherThreads:

« no previous file with comments | « no previous file | no next file » | no next file with comments »