chrome/browser/ui/cocoa/external_protocol_dialog.mm - Issue 10031018: Add a few missing "self = [super init..." notices by the clang static analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/external_protocol_dialog.mm

Issue 10031018: Add a few missing "self = [super init..." notices by the clang static analyzer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/external_protocol_dialog.mm

diff --git a/chrome/browser/ui/cocoa/external_protocol_dialog.mm b/chrome/browser/ui/cocoa/external_protocol_dialog.mm

index 2b6c2ab06189d096849f24594bcf8451f1589802..7d08814d534ae5ca84b3b2119d2effe9414e1596 100644

--- a/chrome/browser/ui/cocoa/external_protocol_dialog.mm

+++ b/chrome/browser/ui/cocoa/external_protocol_dialog.mm

@@ -38,6 +38,9 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(

- (id)initWithGURL:(const GURL*)url {

DCHECK_EQ(MessageLoop::TYPE_UI, MessageLoop::current()->type());

+ if (!(self = [super init]))

+ return nil;

url_ = *url;

creation_time_ = base::Time::Now();

« no previous file with comments | « no previous file | chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm » ('j') | no next file with comments »