Fix issue 22800: Unreachable exception handlers do not have their handler types initialized. Initia…

Fix issue 22800: Unreachable exception handlers do not have their handler types initialized. Initialize the handler info for unreachable handlers as well (instead of crashing).

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44440

[srdjan, 2015-03-12 18:04:25]

srdjan@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-03-12 18:25:09]

LGTM with a couple of nits.

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors.cc
File runtime/vm/code_descriptors.cc (right):

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.cc:101: bool has_catch_all = false;
const bool, or just use the literal false below. I would not hold it against
you.

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.cc:111: bool has_catch_all =
ContainsDynamic(*list_[i].handler_types);
For consistency's sake, also const bool.

[srdjan, 2015-03-12 18:28:44]

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors.cc
File runtime/vm/code_descriptors.cc (right):

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.cc:101: bool has_catch_all = false;
On 2015/03/12 18:25:08, hausner wrote:
> const bool, or just use the literal false below. I would not hold it against
> you.

Done.

https://codereview.chromium.org/1002933002/diff/1/runtime/vm/code_descriptors...
runtime/vm/code_descriptors.cc:111: bool has_catch_all =
ContainsDynamic(*list_[i].handler_types);
On 2015/03/12 18:25:08, hausner wrote:
> For consistency's sake, also const bool.

Done.

[srdjan, 2015-03-12 19:18:24]

Committed patchset #2 (id:20001) manually as r44440 (presubmit successful).