Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: runtime/vm/code_descriptors.cc

Issue 1002933002: Fix issue 22800: Unreachable exception handlers do not have their handler types initialized. Initia… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_descriptors.h ('k') | tests/language/issue22800_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_descriptors.cc
===================================================================
--- runtime/vm/code_descriptors.cc (revision 44434)
+++ runtime/vm/code_descriptors.cc (working copy)
@@ -84,4 +84,41 @@
return map.raw();
}
+
+RawExceptionHandlers* ExceptionHandlerList::FinalizeExceptionHandlers(
+ uword entry_point) const {
+ intptr_t num_handlers = Length();
+ if (num_handlers == 0) {
+ return Object::empty_exception_handlers().raw();
+ }
+ const ExceptionHandlers& handlers =
+ ExceptionHandlers::Handle(ExceptionHandlers::New(num_handlers));
+ for (intptr_t i = 0; i < num_handlers; i++) {
+ // Assert that every element in the array has been initialized.
+ if (list_[i].handler_types == NULL) {
+ // Unreachable handler, entry not computed.
+ // Initialize it to some meaningful value.
+ const bool has_catch_all = false;
+ ASSERT((list_[i].outer_try_index == -1) &&
+ (list_[i].pc_offset == -1)); // It is uninitialized.
+ handlers.SetHandlerInfo(i,
+ list_[i].outer_try_index,
+ list_[i].pc_offset,
+ list_[i].needs_stacktrace,
+ has_catch_all);
+ handlers.SetHandledTypes(i, Array::null_array());
+ } else {
+ const bool has_catch_all = ContainsDynamic(*list_[i].handler_types);
+ handlers.SetHandlerInfo(i,
+ list_[i].outer_try_index,
+ list_[i].pc_offset,
+ list_[i].needs_stacktrace,
+ has_catch_all);
+ handlers.SetHandledTypes(i, *list_[i].handler_types);
+ }
+ }
+ return handlers.raw();
+}
+
+
} // namespace dart
« no previous file with comments | « runtime/vm/code_descriptors.h ('k') | tests/language/issue22800_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698