Issue 1002893002: Cherry-pick r44410 and r44412

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1002893002: Cherry-pick r44410 and r44412 (Closed)

Created:
5 years, 9 months ago by Paul Berry

Modified:
5 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/trunk/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Cherry-pick r44410 and r44412 Manually fixed conflicts: pkg/compiler/lib/src/ssa/optimize.dart BUG=dartbug.com/22795

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -0 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM, assuming that optimize.dart should remain unchanged.

5 years, 9 months ago (2015-03-12 17:38:31 UTC) #3

Paul Berry

5 years, 9 months ago (2015-03-12 17:41:37 UTC) #4

On 2015/03/12 17:38:31, Brian Wilkerson wrote:
> LGTM, assuming that optimize.dart should remain unchanged.

It should, since the only change to optimize.dart was to revert r44333, and
r44333 hasn't been cherry-picked (and won't be necessary to cherry-pick once
this lands).

Thanks for the review.  I'll send the CL to Rico.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages