chrome/test/base/browser_with_test_window_test.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: relax the dcheck Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc ('k') | components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/browser_with_test_window_test.cc

diff --git a/chrome/test/base/browser_with_test_window_test.cc b/chrome/test/base/browser_with_test_window_test.cc

index 09f57d5bb5ac6671de86ffc0761a16a3b4a50716..245c9b9b3117a020754f0d7c1453bcce3d973671 100644

--- a/chrome/test/base/browser_with_test_window_test.cc

+++ b/chrome/test/base/browser_with_test_window_test.cc

@@ -165,12 +165,16 @@ void BrowserWithTestWindowTest::CommitPendingLoad(

if (controller->GetPendingEntryIndex() >= 0) {

test_rfh_tester->SendNavigateWithTransition(

controller->GetPendingEntry()->GetPageID(),

+ controller->GetPendingEntry()->GetUniqueID(),

+ false,

controller->GetPendingEntry()->GetURL(),

controller->GetPendingEntry()->GetTransitionType());

} else {

test_rfh_tester->SendNavigateWithTransition(

controller->GetWebContents()->GetMaxPageIDForSiteInstance(

test_rfh->GetSiteInstance()) + 1,

+ controller->GetPendingEntry()->GetUniqueID(),

+ true,

controller->GetPendingEntry()->GetURL(),

controller->GetPendingEntry()->GetTransitionType());

}