chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: relax the dcheck Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_manager_render_view_host_unittest.cc ('k') | chrome/test/base/browser_with_test_window_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc b/chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc

index 7454e2a1eceb43f430f23ca0cb05ecc7a7b95496..41f39509e19ea0414a6b132f9e01588825733cd4 100644

--- a/chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc

@@ -15,6 +15,8 @@

#include "chrome/common/pref_names.h"

#include "chrome/test/base/testing_profile.h"

#include "components/autofill/core/browser/autofill_test_utils.h"

+#include "content/public/browser/navigation_details.h"

+#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "content/public/test/web_contents_tester.h"

@@ -76,9 +78,19 @@ class GeneratedCreditCardBubbleControllerTest : public testing::Test {

BackingCard());

}

- void NavigateWithTransition(ui::PageTransition trans) {

- content::WebContentsTester::For(test_web_contents_.get())->TestDidNavigate(

- test_web_contents_->GetMainFrame(), 1, GURL("about:blank"), trans);

+ void NavigateWithTransition(ui::PageTransition transition) {

+ content::LoadCommittedDetails details;

+ content::FrameNavigateParams params;

+ // The transition is in two places; fill in both.

+ scoped_ptr<content::NavigationEntry> navigation_entry(

+ content::NavigationEntry::Create());

+ navigation_entry->SetTransitionType(transition);

+ params.transition = transition;

+ details.entry = navigation_entry.get();

+ ASSERT_NE(nullptr, controller());

+ controller()->DidNavigateMainFrame(details, params);

}

private: