Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: content/public/test/test_renderer_host.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: greeeeeeen Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_renderer_host.h
diff --git a/content/public/test/test_renderer_host.h b/content/public/test/test_renderer_host.h
index 029b70ed4db6223111a2340c0857e86315ea5a1b..e9aa8211d6ec52816329a6ad13ade77e63fa527f 100644
--- a/content/public/test/test_renderer_host.h
+++ b/content/public/test/test_renderer_host.h
@@ -74,14 +74,22 @@ class RenderFrameHostTester {
// information. Sets the rest of the parameters in the message to the
// "typical" values. This is a helper function for simulating the most common
// types of loads.
- virtual void SendNavigate(int page_id, const GURL& url) = 0;
- virtual void SendFailedNavigate(int page_id, const GURL& url) = 0;
+ virtual void SendNavigate(int page_id,
+ int nav_entry_id,
Charlie Reis 2015/04/10 23:54:21 Would it help to give some tips for what nav_entry
Avi (use Gerrit) 2015/04/13 22:42:48 I'm not sure. There's no documentation on how to f
+ bool did_create_new_entry,
+ const GURL& url) = 0;
+ virtual void SendFailedNavigate(int page_id,
+ int nav_entry_id,
+ bool did_create_new_entry,
+ const GURL& url) = 0;
// Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
// information, including a custom PageTransition. Sets the rest of the
// parameters in the message to the "typical" values. This is a helper
// function for simulating the most common types of loads.
virtual void SendNavigateWithTransition(int page_id,
+ int nav_entry_id,
+ bool did_create_new_entry,
const GURL& url,
ui::PageTransition transition) = 0;

Powered by Google App Engine
This is Rietveld 408576698