Classify navigations without page id in parallel to the existing classifier.

content/public/test/test_renderer_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_
 #define CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "content/public/browser/render_frame_host.h"
@@ skipping 56 matching lines @@
   virtual ~RenderFrameHostTester() {}
 
   // Gives tests access to RenderFrameHostImpl::OnCreateChild. The returned
   // RenderFrameHost is owned by the parent RenderFrameHost.
   virtual RenderFrameHost* AppendChild(const std::string& frame_name) = 0;
 
   // Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
   // information. Sets the rest of the parameters in the message to the
   // "typical" values. This is a helper function for simulating the most common
   // types of loads.
-  virtual void SendNavigate(int page_id, const GURL& url) = 0;
-  virtual void SendFailedNavigate(int page_id, const GURL& url) = 0;
+  virtual void SendNavigate(int page_id,
+                            int nav_entry_id,

[Charlie Reis, 2015/04/10 23:54:21]

Would it help to give some tips for what nav_entry_id should be set to (e.g.,
when it's 0 or not)?

Also, maybe a TODO that page_id is going away?

[Avi (use Gerrit), 2015/04/13 22:42:48]

I'm not sure. There's no documentation on how to fill out the page_id field in
this and a zillion other calls.
If I did that, half this patch would be TODOs :)

+                            bool did_create_new_entry,
+                            const GURL& url) = 0;
+  virtual void SendFailedNavigate(int page_id,
+                                  int nav_entry_id,
+                                  bool did_create_new_entry,
+                                  const GURL& url) = 0;
 
   // Calls OnDidCommitProvisionalLoad on the RenderFrameHost with the given
   // information, including a custom PageTransition.  Sets the rest of the
   // parameters in the message to the "typical" values. This is a helper
   // function for simulating the most common types of loads.
   virtual void SendNavigateWithTransition(int page_id,
+                                          int nav_entry_id,
+                                          bool did_create_new_entry,
                                           const GURL& url,
                                           ui::PageTransition transition) = 0;
 
   // If set, future loads will have |mime_type| set as the mime type.
   // If not set, the mime type will default to "text/html".
   virtual void SetContentsMimeType(const std::string& mime_type) = 0;
 
   // Calls OnBeforeUnloadACK on this RenderFrameHost with the given parameter.
   virtual void SendBeforeUnloadACK(bool proceed) = 0;
 
@@ skipping 151 matching lines @@
 
   int thread_bundle_options_;
   scoped_ptr<TestBrowserThreadBundle> thread_bundle_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostTestHarness);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_