Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1002673002: Remove funky 2-stage initialization of ParserInfo and an adventurous memset. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove funky 2-stage initialization of ParserInfo and an adventurous memset. R=titzer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/40567349df1f5fbd09a339d400764b9df6780af0

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -64 lines) Patch
M src/compiler.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/parser.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M src/parser.cc View 3 chunks +22 lines, -9 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 10 chunks +10 lines, -20 lines 0 comments Download
M tools/parser-shell.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-12 10:34:03 UTC) #2
titzer
lgtm if TODOs are removed https://codereview.chromium.org/1002673002/diff/1/src/parser.h File src/parser.h (right): https://codereview.chromium.org/1002673002/diff/1/src/parser.h#newcode28 src/parser.h:28: // TODO(titzer) Make this ...
5 years, 9 months ago (2015-03-12 11:33:40 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/40567349df1f5fbd09a339d400764b9df6780af0 Cr-Commit-Position: refs/heads/master@{#27155}
5 years, 9 months ago (2015-03-12 11:46:38 UTC) #5
Sven Panne
5 years, 9 months ago (2015-03-12 11:46:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
40567349df1f5fbd09a339d400764b9df6780af0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698