Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/parser.h

Issue 1002673002: Remove funky 2-stage initialization of ParserInfo and an adventurous memset. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed TODOs Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSER_H_ 5 #ifndef V8_PARSER_H_
6 #define V8_PARSER_H_ 6 #define V8_PARSER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast.h" 9 #include "src/ast.h"
10 #include "src/compiler.h" // TODO(titzer): remove this include dependency 10 #include "src/compiler.h" // TODO(titzer): remove this include dependency
11 #include "src/pending-compilation-error-handler.h" 11 #include "src/pending-compilation-error-handler.h"
12 #include "src/preparse-data.h" 12 #include "src/preparse-data.h"
13 #include "src/preparse-data-format.h" 13 #include "src/preparse-data-format.h"
14 #include "src/preparser.h" 14 #include "src/preparser.h"
15 #include "src/scopes.h" 15 #include "src/scopes.h"
16 16
17 namespace v8 { 17 namespace v8 {
18 18
19 class ScriptCompiler; 19 class ScriptCompiler;
20 20
21 namespace internal { 21 namespace internal {
22 22
23 class Target; 23 class Target;
24 24
25 // A container for the inputs, configuration options, and outputs of parsing. 25 // A container for the inputs, configuration options, and outputs of parsing.
26 class ParseInfo { 26 class ParseInfo {
27 public: 27 public:
28 explicit ParseInfo(Zone* zone) { 28 explicit ParseInfo(Zone* zone);
29 memset(this, 0, sizeof(ParseInfo)); 29 ParseInfo(Zone* zone, Handle<JSFunction> function);
30 zone_ = zone; 30 ParseInfo(Zone* zone, Handle<SharedFunctionInfo> shared);
31 } 31 ParseInfo(Zone* zone, Handle<Script> script);
32 32
33 ~ParseInfo() { 33 ~ParseInfo() {
34 if (ast_value_factory_owned()) { 34 if (ast_value_factory_owned()) {
35 delete ast_value_factory_; 35 delete ast_value_factory_;
36 set_ast_value_factory_owned(false); 36 set_ast_value_factory_owned(false);
37 } 37 }
38 ast_value_factory_ = nullptr; 38 ast_value_factory_ = nullptr;
39 } 39 }
40 40
41 ParseInfo* InitializeFromJSFunction(Handle<JSFunction> function);
42 ParseInfo* InitializeFromSharedFunctionInfo(
43 Handle<SharedFunctionInfo> shared);
44 ParseInfo* InitializeFromScript(Handle<Script> script);
45
46 Zone* zone() { return zone_; } 41 Zone* zone() { return zone_; }
47 42
48 // Convenience accessor methods for flags. 43 // Convenience accessor methods for flags.
49 #define FLAG_ACCESSOR(flag, getter, setter) \ 44 #define FLAG_ACCESSOR(flag, getter, setter) \
50 bool getter() const { return GetFlag(flag); } \ 45 bool getter() const { return GetFlag(flag); } \
51 void setter() { SetFlag(flag); } \ 46 void setter() { SetFlag(flag); } \
52 void setter(bool val) { SetFlag(flag, val); } 47 void setter(bool val) { SetFlag(flag, val); }
53 48
54 FLAG_ACCESSOR(kToplevel, is_toplevel, set_toplevel) 49 FLAG_ACCESSOR(kToplevel, is_toplevel, set_toplevel)
55 FLAG_ACCESSOR(kLazy, is_lazy, set_lazy) 50 FLAG_ACCESSOR(kLazy, is_lazy, set_lazy)
(...skipping 1072 matching lines...) Expand 10 before | Expand all | Expand 10 after
1128 } 1123 }
1129 1124
1130 1125
1131 Expression* ParserTraits::CloseTemplateLiteral(TemplateLiteralState* state, 1126 Expression* ParserTraits::CloseTemplateLiteral(TemplateLiteralState* state,
1132 int start, Expression* tag) { 1127 int start, Expression* tag) {
1133 return parser_->CloseTemplateLiteral(state, start, tag); 1128 return parser_->CloseTemplateLiteral(state, start, tag);
1134 } 1129 }
1135 } } // namespace v8::internal 1130 } } // namespace v8::internal
1136 1131
1137 #endif // V8_PARSER_H_ 1132 #endif // V8_PARSER_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698