Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: grit/format/html_inline.py

Issue 1002663003: Raises an exception when an unexpected </if> occurs (Closed) Base URL: http://grit-i18n.googlecode.com/svn/trunk/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | grit/format/html_inline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: grit/format/html_inline.py
===================================================================
--- grit/format/html_inline.py (revision 188)
+++ grit/format/html_inline.py (working copy)
@@ -184,6 +184,8 @@
while True:
begin_if = _BEGIN_IF_BLOCK.search(str)
if begin_if is None:
+ if _END_IF_BLOCK.search(str) is not None:
+ raise Exception('Unexpected </if>')
Nico 2015/03/26 17:58:56 Should this be 'Unmatched </if>' to match the simi
return str
condition_satisfied = IsConditionSatisfied(begin_if)
« no previous file with comments | « no previous file | grit/format/html_inline_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698