Raises an exception when an unexpected </if> occurs

Raises an exception when an unmatched </if> occurs

r189

[François Beaufort, 2015-03-26 12:04:29]

beaufort.francois@gmail.com changed reviewers:
+ thakis@chromium.org

[François Beaufort, 2015-03-26 12:05:48]

Hello Nico,

Here's the promised patch that makes grit raise an exception when an </if> tag
with no <if> tag associated is detected.

[Nico, 2015-03-26 17:58:56]

lgtm, thanks! Let me know if you want me to land this as-is or if you want to
address the comment below.

https://codereview.chromium.org/1002663003/diff/40001/grit/format/html_inline.py
File grit/format/html_inline.py (right):

https://codereview.chromium.org/1002663003/diff/40001/grit/format/html_inline...
grit/format/html_inline.py:188: raise Exception('Unexpected </if>')
Should this be 'Unmatched </if>' to match the similar message a few lines down?

[François Beaufort, 2015-03-27 09:53:11]

On 2015/03/26 17:58:56, Nico (away until Monday) wrote:
> lgtm, thanks! Let me know if you want me to land this as-is or if you want to
> address the comment below.
> 
>
https://codereview.chromium.org/1002663003/diff/40001/grit/format/html_inline.py
> File grit/format/html_inline.py (right):
> 
>
https://codereview.chromium.org/1002663003/diff/40001/grit/format/html_inline...
> grit/format/html_inline.py:188: raise Exception('Unexpected </if>')
> Should this be 'Unmatched </if>' to match the similar message a few lines
down?

I've addressed your comment and will land it.

For info, I've built chromium with these grit changes and only one file is
having an issue:
chrome/browser/resources/options/browser_options.html has two </if>

[François Beaufort, 2015-03-27 09:53:14]

The CQ bit was checked by beaufort.francois@gmail.com

[François Beaufort, 2015-03-27 09:53:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1002663003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-27 09:55:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-27 09:55:41]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[François Beaufort, 2015-03-27 10:15:46]

On 2015/03/27 09:55:41, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Hey Nico, as you can see Base URL seems to be bad. 
I guess that's because I'm not a committer ;)

Please, can you land this change?

[Nico, 2015-03-30 21:25:59]

Landed in grit r189. Thanks for the patch!

Please roll grit in Chromium soon, to make sure that Chromium's grd files don't
trip over this warning.

(Sorry about the slow turnaround, I was on vacation last Friday)

[François Beaufort, 2015-03-31 08:14:42]

On 2015/03/30 21:25:59, Nico wrote:
> Landed in grit r189. Thanks for the patch!
> 
> Please roll grit in Chromium soon, to make sure that Chromium's grd files
don't
> trip over this warning.
> 
> (Sorry about the slow turnaround, I was on vacation last Friday)

Hope you had a great week-end then.

Both CL have been uploaded and waiting to be reviewed.