Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1002583002: Fix Windows build. (Closed)

Created:
5 years, 9 months ago by scroggo
Modified:
5 years, 9 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org, David Lattimore
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Windows build. SK_BUILD_FOR_WIN is no longer a valid way to check for building on Windows (go figure). Build everywhere. Remove the REPORTER_ASSERT, which was the failing part. It also isn't necessary for the test, which is just that we are not leaking an SkColorTable. Also fix indentation. TBR=bungeman@google.com,mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3457 Committed: https://skia.googlesource.com/skia/+/dd8c637bc74be9a03c5738e6b37f62bbd653846b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M tests/InvalidIndexedPngTest.cpp View 2 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scroggo
5 years, 9 months ago (2015-03-11 20:57:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002583002/1
5 years, 9 months ago (2015-03-11 20:58:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/dd8c637bc74be9a03c5738e6b37f62bbd653846b
5 years, 9 months ago (2015-03-11 20:58:21 UTC) #4
mtklein
5 years, 9 months ago (2015-03-11 21:24:27 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698