Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/common/extensions/feature_unittest.cc

Issue 10025007: Convert tabs, windows, and extension APIs to feature system. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blah Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/feature.cc ('k') | chrome/common/extensions/permission_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/feature_unittest.cc
diff --git a/chrome/common/extensions/feature_unittest.cc b/chrome/common/extensions/feature_unittest.cc
index c4cc1a3addafdc3c74a463b28097f5ed825450ef..25be4c37e791e2020b9dbcbbb11731b3024311d7 100644
--- a/chrome/common/extensions/feature_unittest.cc
+++ b/chrome/common/extensions/feature_unittest.cc
@@ -377,6 +377,7 @@ TEST(ExtensionFeatureTest, Inheritance) {
TEST(ExtensionFeatureTest, Equals) {
Feature feature;
+ feature.set_name("monkey");
feature.whitelist()->insert("foo");
feature.extension_types()->insert(Extension::TYPE_THEME);
feature.contexts()->insert(Feature::UNBLESSED_EXTENSION_CONTEXT);
@@ -388,6 +389,10 @@ TEST(ExtensionFeatureTest, Equals) {
Feature feature2(feature);
EXPECT_TRUE(feature2.Equals(feature));
+ feature2.set_name("");
+ EXPECT_FALSE(feature2.Equals(feature));
+
+ feature2 = feature;
feature2.whitelist()->clear();
EXPECT_FALSE(feature2.Equals(feature));
@@ -415,3 +420,32 @@ TEST(ExtensionFeatureTest, Equals) {
feature2.set_max_manifest_version(0);
EXPECT_FALSE(feature2.Equals(feature));
}
+
+TEST(ExtensionFeatureTest, IsEmpty) {
+ Feature feature;
+ EXPECT_TRUE(feature.IsEmpty());
+
+ Feature feature2 = feature;
+ feature2.set_name("monkey");
+ EXPECT_TRUE(feature2.IsEmpty());
+
+ feature2 = feature;
+ feature2.whitelist()->insert("monkey");
+ EXPECT_FALSE(feature2.IsEmpty());
+
+ feature2 = feature;
+ feature2.extension_types()->insert(Extension::TYPE_THEME);
+ EXPECT_FALSE(feature2.IsEmpty());
+
+ feature2 = feature;
+ feature2.contexts()->insert(Feature::CONTENT_SCRIPT_CONTEXT);
+ EXPECT_FALSE(feature2.IsEmpty());
+
+ feature2 = feature;
+ feature2.set_location(Feature::COMPONENT_LOCATION);
+ EXPECT_FALSE(feature2.IsEmpty());
+
+ feature2 = feature;
+ feature2.set_platform(Feature::CHROMEOS_PLATFORM);
+ EXPECT_FALSE(feature2.IsEmpty());
+}
« no previous file with comments | « chrome/common/extensions/feature.cc ('k') | chrome/common/extensions/permission_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698