Convert tabs, windows, and extension APIs to feature system.

chrome/common/extensions/feature_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/feature.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 using extensions::Feature;
 
@@ skipping 359 matching lines @@
   EXPECT_EQ(1u, feature2.whitelist()->count("bar"));
   EXPECT_EQ(1u, feature2.extension_types()->count(Extension::TYPE_EXTENSION));
   EXPECT_EQ(1u,
             feature2.contexts()->count(Feature::UNBLESSED_EXTENSION_CONTEXT));
   EXPECT_EQ(2, feature2.min_manifest_version());
   EXPECT_EQ(3, feature2.max_manifest_version());
 }
 
 TEST(ExtensionFeatureTest, Equals) {
   Feature feature;
+  feature.set_name("monkey");
   feature.whitelist()->insert("foo");
   feature.extension_types()->insert(Extension::TYPE_THEME);
   feature.contexts()->insert(Feature::UNBLESSED_EXTENSION_CONTEXT);
   feature.set_location(Feature::COMPONENT_LOCATION);
   feature.set_platform(Feature::CHROMEOS_PLATFORM);
   feature.set_min_manifest_version(18);
   feature.set_max_manifest_version(25);
 
   Feature feature2(feature);
   EXPECT_TRUE(feature2.Equals(feature));
 
+  feature2.set_name("");
+  EXPECT_FALSE(feature2.Equals(feature));
+
+  feature2 = feature;
   feature2.whitelist()->clear();
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.extension_types()->clear();
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.contexts()->clear();
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.set_location(Feature::UNSPECIFIED_LOCATION);
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.set_platform(Feature::UNSPECIFIED_PLATFORM);
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.set_min_manifest_version(0);
   EXPECT_FALSE(feature2.Equals(feature));
 
   feature2 = feature;
   feature2.set_max_manifest_version(0);
   EXPECT_FALSE(feature2.Equals(feature));
 }
+
+TEST(ExtensionFeatureTest, IsEmpty) {
+  Feature feature;
+  EXPECT_TRUE(feature.IsEmpty());
+
+  Feature feature2 = feature;
+  feature2.set_name("monkey");
+  EXPECT_TRUE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.whitelist()->insert("monkey");
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.extension_types()->insert(Extension::TYPE_THEME);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.contexts()->insert(Feature::CONTENT_SCRIPT_CONTEXT);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.set_location(Feature::COMPONENT_LOCATION);
+  EXPECT_FALSE(feature2.IsEmpty());
+
+  feature2 = feature;
+  feature2.set_platform(Feature::CHROMEOS_PLATFORM);
+  EXPECT_FALSE(feature2.IsEmpty());
+}