Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1002493004: Clear RenderFrameImpl::frame_ pointer after deleting it. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Clear RenderFrameImpl::frame_ pointer after deleting it. Also avoid dereferencing it in OnMessageReceived after deletion. NOTRY=true TBR=nasko BUG=461191 TEST=No more crashes in RenderFrameImpl::OnMessageReceived Review URL: https://codereview.chromium.org/1007123003 Cr-Commit-Position: refs/heads/master@{#320773} (cherry picked from commit cfaa4468f3394995a9f1565104ee2743a30d58e0)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Charlie Reis
TBR'ing Nasko for this merge to the M42 branch.
5 years, 9 months ago (2015-03-19 16:15:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002493004/1
5 years, 9 months ago (2015-03-19 16:19:17 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:20:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698