Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1002423003: Oilpan: Build fix after r192015 (Closed)

Created:
5 years, 9 months ago by haraken
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, bokan, sof
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/RotationViewportAnchor.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
haraken
5 years, 9 months ago (2015-03-17 15:44:37 UTC) #2
haraken
Committed patchset #1 (id:1) manually as 192017 (presubmit successful).
5 years, 9 months ago (2015-03-17 15:44:57 UTC) #3
sof
lgtm. (looks like we _might_ be able to make this a stack allocated object & ...
5 years, 9 months ago (2015-03-17 15:49:58 UTC) #4
sof
On 2015/03/17 15:49:58, sof wrote: > lgtm. > > (looks like we _might_ be able ...
5 years, 9 months ago (2015-03-17 15:50:39 UTC) #5
haraken
5 years, 9 months ago (2015-03-17 15:56:31 UTC) #6
Message was sent while issue was closed.
On 2015/03/17 15:50:39, sof wrote:
> On 2015/03/17 15:49:58, sof wrote:
> > lgtm.
> > 
> > (looks like we _might_ be able to make this a stack allocated object & trace
> its
> > references that way.)
> 
> I can follow up on that.

Good point, thanks!

Powered by Google App Engine
This is Rietveld 408576698