Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1002283005: Add an error page for net::ERR_ICANN_NAME_COLLISION. (Closed)

Created:
5 years, 9 months ago by eroman
Modified:
5 years, 8 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dns_53
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an error page for net::ERR_ICANN_NAME_COLLISION. BUG=470704 Committed: https://crrev.com/c32e6630654aa39144770341f70d8dcf7958a146 Cr-Commit-Position: refs/heads/master@{#322658}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Patch Set 3 : rebase (dependent change now landed) #

Total comments: 2

Patch Set 4 : Remove non error page stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/localized_error.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (7 generated)
eroman
https://codereview.chromium.org/1002283005/diff/1/build/ios/grit_whitelist.txt File build/ios/grit_whitelist.txt (right): https://codereview.chromium.org/1002283005/diff/1/build/ios/grit_whitelist.txt#newcode351 build/ios/grit_whitelist.txt:351: IDS_ERRORPAGES_DETAILS_ICANN_NAME_COLLISION Not sure why/if this is needed, but turned ...
5 years, 9 months ago (2015-03-26 02:00:18 UTC) #2
Ryan Sleevi
Adrienne, Elisabeth, FYI
5 years, 9 months ago (2015-03-26 02:06:12 UTC) #4
eroman
Patchset 1 looks as follows: http://i.imgur.com/739ljuT.png http://i.imgur.com/UqS0ABa.png
5 years, 9 months ago (2015-03-26 02:08:42 UTC) #5
Ryan Sleevi
https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resources.grd#newcode9296 chrome/app/generated_resources.grd:9296: + indicates there was a name collision. The error ...
5 years, 9 months ago (2015-03-26 02:09:43 UTC) #6
eroman
Done. Patchset2 now looks like this: Expanded details: http://i.imgur.com/xOeUxGh.png Error in an iframe (with focus): ...
5 years, 9 months ago (2015-03-26 03:15:26 UTC) #7
mmenke
https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd#newcode9297 chrome/app/generated_resources.grd:9297: + <ph name="BEGIN_LINK">&lt;a href="https://support.google.com/chrome/?p=top_level_domain&amp;hl=[GRITLANGCODE]"&gt;</ph>new generic top-level domain<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> This ...
5 years, 9 months ago (2015-03-26 14:44:43 UTC) #8
eroman
https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd#newcode9297 chrome/app/generated_resources.grd:9297: + <ph name="BEGIN_LINK">&lt;a href="https://support.google.com/chrome/?p=top_level_domain&amp;hl=[GRITLANGCODE]"&gt;</ph>new generic top-level domain<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph> On ...
5 years, 9 months ago (2015-03-26 14:58:30 UTC) #9
mmenke
On 2015/03/26 14:58:30, eroman wrote: > https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_resources.grd#newcode9297 > ...
5 years, 9 months ago (2015-03-26 14:59:56 UTC) #10
eroman
I just removed the non-error page stuff from the CL and revised the description. (Makes ...
5 years, 9 months ago (2015-03-26 15:04:43 UTC) #11
eroman
egm/felt: Any opposition to landing this? Per feedback I have filed a launch bug here: ...
5 years, 8 months ago (2015-03-27 18:32:34 UTC) #12
felt
On 2015/03/27 18:32:34, eroman wrote: > egm/felt: Any opposition to landing this? > > Per ...
5 years, 8 months ago (2015-03-27 19:02:37 UTC) #13
eroman
Alright will ping Alex. I believe I can forward with landing this so it can ...
5 years, 8 months ago (2015-03-27 19:49:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002283005/60001
5 years, 8 months ago (2015-03-27 20:21:30 UTC) #17
felt
On 2015/03/27 19:49:44, eroman wrote: > Alright will ping Alex. > > I believe I ...
5 years, 8 months ago (2015-03-27 20:29:07 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52412)
5 years, 8 months ago (2015-03-27 20:32:09 UTC) #20
eroman
+thestig for OWNERS review of localized_error.cc
5 years, 8 months ago (2015-03-27 20:55:31 UTC) #22
Lei Zhang
lgtm
5 years, 8 months ago (2015-03-27 21:12:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002283005/60001
5 years, 8 months ago (2015-03-27 22:15:24 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-03-27 22:19:15 UTC) #26
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 22:19:53 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c32e6630654aa39144770341f70d8dcf7958a146
Cr-Commit-Position: refs/heads/master@{#322658}

Powered by Google App Engine
This is Rietveld 408576698