Add an error page for net::ERR_ICANN_NAME_COLLISION.

Add an error page for net::ERR_ICANN_NAME_COLLISION.

BUG=470704
Committed: https://crrev.com/c32e6630654aa39144770341f70d8dcf7958a146
Cr-Commit-Position: refs/heads/master@{#322658}

[eroman, 2015-03-26 02:00:17]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org, rsleevi@chromium.org

[eroman, 2015-03-26 02:00:18]

https://codereview.chromium.org/1002283005/diff/1/build/ios/grit_whitelist.txt
File build/ios/grit_whitelist.txt (right):

https://codereview.chromium.org/1002283005/diff/1/build/ios/grit_whitelist.tx...
build/ios/grit_whitelist.txt:351: IDS_ERRORPAGES_DETAILS_ICANN_NAME_COLLISION
Not sure why/if this is needed, but turned up in my search of places...

[Ryan Sleevi, 2015-03-26 02:06:11]

rsleevi@chromium.org changed reviewers:
+ egm@chromium.org, felt@chromium.org

[Ryan Sleevi, 2015-03-26 02:06:12]

Adrienne, Elisabeth, FYI

[eroman, 2015-03-26 02:08:42]

Patchset 1 looks as follows:

  http://i.imgur.com/739ljuT.png
  http://i.imgur.com/UqS0ABa.png

[Ryan Sleevi, 2015-03-26 02:09:43]

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9296: +        indicates there was a name
collision.
The error message that Alex & Elisabeth came up with is, I believe

"This site is using a <link to help center> new generic top-level domain</link>
(gTLD). If you have used <ph name="HOSTNAME">&lt;strong
jscontent="hostName"&gt;&lt;/strong&gt;<ex>the.koalas.are.sleepy</ex></ph> to
access an internal site in the past, contact your network administrator."

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9489: +        The server's DNS resolved to
127.0.53.53.
I'm not sure where this fits on the error page. I think the mockups were just
"This webpage is not available."

[eroman, 2015-03-26 03:15:26]

Done. Patchset2 now looks like this:

Expanded details:
  http://i.imgur.com/xOeUxGh.png


Error in an iframe (with focus):
  http://i.imgur.com/zLUfhkj.png

Error in an iframe (without focus):
   http://i.imgur.com/X04bxne.png

I used the following URL (however it doesn't display anything ATM):

  https://support.google.com/chrome/?p=top_level_domain&hl=<LANGUAGE>

Where language is something like "en".

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9296: +        indicates there was a name
collision.
On 2015/03/26 02:09:42, Ryan Sleevi wrote:
> The error message that Alex & Elisabeth came up with is, I believe
> 
> "This site is using a <link to help center> new generic top-level
domain</link>
> (gTLD). If you have used <ph name="HOSTNAME">&lt;strong
> jscontent="hostName"&gt;&lt;/strong&gt;<ex>the.koalas.are.sleepy</ex></ph> to
> access an internal site in the past, contact your network administrator."

Done.

https://codereview.chromium.org/1002283005/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:9489: +        The server's DNS resolved to
127.0.53.53.
On 2015/03/26 02:09:43, Ryan Sleevi wrote:
> I'm not sure where this fits on the error page. I think the mockups were just
> "This webpage is not available."

This string is displayed when you mouseover iframes containing errors. For
instance here is what an iframe with the error looks like with now focus:

http://i.imgur.com/X04bxne.png

And then when you rollover it pops the string:

http://i.imgur.com/zLUfhkj.png

[mmenke, 2015-03-26 14:44:43]

https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9297: +        <ph name="BEGIN_LINK">&lt;a
href="https://support.google.com/chrome/?p=top_level_domain&amp;hl=[GRITLANGCODE]"&gt;</ph>new
generic top-level domain<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
This seems weird - why is there an example ("ex") when we aren't substituting
anything in other than the language code?  Looks like this is done elsewhere, so
this may be correct, but seems strange.

[eroman, 2015-03-26 14:58:30]

https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9297: +        <ph name="BEGIN_LINK">&lt;a
href="https://support.google.com/chrome/?p=top_level_domain&amp;hl=[GRITLANGCODE]"&gt;</ph>new
generic top-level domain<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
On 2015/03/26 14:44:43, mmenke wrote:
> This seems weird - why is there an example ("ex") when we aren't substituting
> anything in other than the language code?  Looks like this is done elsewhere,
so
> this may be correct, but seems strange.

I copy pasted the line from another place and then just changed the URL and
text.
To be honest I don't understand the the <ex> either.

[mmenke, 2015-03-26 14:59:56]

On 2015/03/26 14:58:30, eroman wrote:
>
https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
> 
>
https://codereview.chromium.org/1002283005/diff/40001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:9297: +        <ph name="BEGIN_LINK">&lt;a
>
href="https://support.google.com/chrome/?p=top_level_domain&amp;hl=[GRITLANGCODE]"&gt;</ph>new
> generic top-level domain<ph name="END_LINK">&lt;/a&gt;<ex>&lt;/a&gt;</ex></ph>
> On 2015/03/26 14:44:43, mmenke wrote:
> > This seems weird - why is there an example ("ex") when we aren't
substituting
> > anything in other than the language code?  Looks like this is done
elsewhere,
> so
> > this may be correct, but seems strange.
> 
> I copy pasted the line from another place and then just changed the URL and
> text.
> To be honest I don't understand the the <ex> either.

Good enough for me.  LGTM.

[eroman, 2015-03-26 15:04:43]

I just removed the non-error page stuff from the CL and revised the description.

(Makes more sense to propose the other changes separately)

[eroman, 2015-03-27 18:32:34]

egm/felt: Any opposition to landing this?

Per feedback I have filed a launch bug here:
https://code.google.com/p/chromium/issues/detail?id=470989

And accompanying design document here:

https://docs.google.com/document/d/123BYF7vcgAPq5oTiwuhKJfRNMTPmOFgofl2ZkQHOB...

[felt, 2015-03-27 19:02:37]

On 2015/03/27 18:32:34, eroman wrote:
> egm/felt: Any opposition to landing this?
> 
> Per feedback I have filed a launch bug here:
> https://code.google.com/p/chromium/issues/detail?id=470989
> 
> And accompanying design document here:
> 
>
https://docs.google.com/document/d/123BYF7vcgAPq5oTiwuhKJfRNMTPmOFgofl2ZkQHOB...

I flipped the security bit, I am happy with the warning. You'll want to ping
Alex Ainslie (or maybe egm can help you channel Alex) to get the UI bit flipped.

[eroman, 2015-03-27 19:49:44]

Alright will ping Alex.

I believe I can forward with landing this so it can start being tested. However
of course I will respond to any feedback or necessary revert following the UI
launch review.

Thanks

[eroman, 2015-03-27 20:20:59]

The CQ bit was checked by eroman@chromium.org

[eroman, 2015-03-27 20:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1002283005/#ps60001
(title: "Remove non error page stuff")

[commit-bot: I haz the power, 2015-03-27 20:21:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002283005/60001

[felt, 2015-03-27 20:29:07]

On 2015/03/27 19:49:44, eroman wrote:
> Alright will ping Alex.
> 
> I believe I can forward with landing this so it can start being tested.
However
> of course I will respond to any feedback or necessary revert following the UI
> launch review.
> 
> Thanks

Do you have a PM to help you with the launch process? Maybe sidv? I find that
they can help make all this launch stuff easier. :)

[commit-bot: I haz the power, 2015-03-27 20:32:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-27 20:32:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eroman, 2015-03-27 20:55:30]

eroman@chromium.org changed reviewers:
+ thestig@chromium.org

[eroman, 2015-03-27 20:55:31]

+thestig for OWNERS review of localized_error.cc

[Lei Zhang, 2015-03-27 21:12:02]

lgtm

[eroman, 2015-03-27 22:14:47]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-03-27 22:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002283005/60001

[commit-bot: I haz the power, 2015-03-27 22:19:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-27 22:19:53]

Patchset 4 (id:??) landed as
https://crrev.com/c32e6630654aa39144770341f70d8dcf7958a146
Cr-Commit-Position: refs/heads/master@{#322658}