Source/bindings/templates/constants.cpp - Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/constants.cpp

Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/constants.cpp

diff --git a/Source/bindings/templates/constants.cpp b/Source/bindings/templates/constants.cpp

index 36be49e1369915f051393b95ab27eac217995ab0..b88c373a8e0f2b0b03028df38dce0a9f5aa47d4e 100644

--- a/Source/bindings/templates/constants.cpp

+++ b/Source/bindings/templates/constants.cpp

@@ -1,7 +1,7 @@

{##############################################################################}

{% macro constant_getter_callback(constant) %}

{% filter conditional(constant.conditional_string) %}

-static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

+static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info)

{

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

{% if constant.deprecate_as %}

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')