Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: Source/bindings/core/v8/V8DOMConfiguration.cpp

Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8DOMConfiguration.cpp
diff --git a/Source/bindings/core/v8/V8DOMConfiguration.cpp b/Source/bindings/core/v8/V8DOMConfiguration.cpp
index 6a1c9403c76fba3a6ab7f58f8b2c475136917725..9001166137f002e8753714bb1552c7663b51d1ea 100644
--- a/Source/bindings/core/v8/V8DOMConfiguration.cpp
+++ b/Source/bindings/core/v8/V8DOMConfiguration.cpp
@@ -43,8 +43,8 @@ void installAttributeInternal(v8::Isolate* isolate, v8::Handle<ObjectOrTemplate>
&& !world.isPrivateScriptIsolatedWorld())
return;
- v8::AccessorGetterCallback getter = attribute.getter;
- v8::AccessorSetterCallback setter = attribute.setter;
+ v8::AccessorNameGetterCallback getter = attribute.getter;
+ v8::AccessorNameSetterCallback setter = attribute.setter;
if (world.isMainWorld()) {
if (attribute.getterForMainWorld)
getter = attribute.getterForMainWorld;
@@ -205,7 +205,7 @@ void V8DOMConfiguration::installConstant(v8::Isolate* isolate, v8::Handle<v8::Fu
installConstantInternal(isolate, functionDescriptor, prototypeTemplate, constant);
}
-void V8DOMConfiguration::installConstantWithGetter(v8::Isolate* isolate, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const char* name, v8::AccessorGetterCallback getter)
+void V8DOMConfiguration::installConstantWithGetter(v8::Isolate* isolate, v8::Handle<v8::FunctionTemplate> functionDescriptor, v8::Handle<v8::ObjectTemplate> prototypeTemplate, const char* name, v8::AccessorNameGetterCallback getter)
{
v8::Handle<v8::String> constantName = v8AtomicString(isolate, name);
v8::PropertyAttribute attributes =

Powered by Google App Engine
This is Rietveld 408576698