Source/bindings/templates/constants.cpp - Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/templates/constants.cpp

Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

OLD	NEW
1 {##############################################################################}	1 {##############################################################################}

2 {% macro constant_getter_callback(constant) %}	2 {% macro constant_getter_callback(constant) %}

3 {% filter conditional(constant.conditional_string) %}	3 {% filter conditional(constant.conditional_string) %}

4 static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)	4 static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v 8::PropertyCallbackInfo<v8::Value>& info)

5 {	5 {

6 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");	6 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");

7 {% if constant.deprecate_as %}	7 {% if constant.deprecate_as %}

8 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{constant.deprecate_as}});	8 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{constant.deprecate_as}});

9 {% endif %}	9 {% endif %}

10 {% if constant.measure_as %}	10 {% if constant.measure_as %}

11 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{constant.measure_as('ConstantGetter')}});	11 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{constant.measure_as('ConstantGetter')}});

12 {% endif %}	12 {% endif %}

13 {% if constant.idl_type in ('Double', 'Float') %}	13 {% if constant.idl_type in ('Double', 'Float') %}

14 v8SetReturnValue(info, {{constant.value}});	14 v8SetReturnValue(info, {{constant.value}});

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 {% if constant.idl_type in ('Double', 'Float') %}	62 {% if constant.idl_type in ('Double', 'Float') %}

63 {% set value = '0, %s, 0' % constant.value %}	63 {% set value = '0, %s, 0' % constant.value %}

64 {% elif constant.idl_type == 'String' %}	64 {% elif constant.idl_type == 'String' %}

65 {% set value = '0, 0, "%s"' % constant.value %}	65 {% set value = '0, 0, "%s"' % constant.value %}

66 {% else %}	66 {% else %}

67 {# 'Short', 'Long' etc. #}	67 {# 'Short', 'Long' etc. #}

68 {% set value = '%s, 0, 0' % constant.value %}	68 {% set value = '%s, 0, 0' % constant.value %}

69 {% endif %}	69 {% endif %}

70 {"{{constant.name}}", {{value}}, V8DOMConfiguration::ConstantType{{constant.idl_ type}}}	70 {"{{constant.name}}", {{value}}, V8DOMConfiguration::ConstantType{{constant.idl_ type}}}

71 {%- endmacro %}	71 {%- endmacro %}

OLD	NEW