Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/bindings/templates/attributes.cpp

Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/templates/constants.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% from 'conversions.cpp' import v8_value_to_local_cpp_value %} 1 {% from 'conversions.cpp' import v8_value_to_local_cpp_value %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% macro attribute_getter(attribute, world_suffix) %} 5 {% macro attribute_getter(attribute, world_suffix) %}
6 {% filter conditional(attribute.conditional_string) %} 6 {% filter conditional(attribute.conditional_string) %}
7 static void {{attribute.name}}AttributeGetter{{world_suffix}}( 7 static void {{attribute.name}}AttributeGetter{{world_suffix}}(
8 {%- if attribute.is_expose_js_accessors %} 8 {%- if attribute.is_expose_js_accessors %}
9 const v8::FunctionCallbackInfo<v8::Value>& info 9 const v8::FunctionCallbackInfo<v8::Value>& info
10 {%- else %} 10 {%- else %}
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 {% endmacro %} 142 {% endmacro %}
143 143
144 144
145 {##############################################################################} 145 {##############################################################################}
146 {% macro attribute_getter_callback(attribute, world_suffix) %} 146 {% macro attribute_getter_callback(attribute, world_suffix) %}
147 {% filter conditional(attribute.conditional_string) %} 147 {% filter conditional(attribute.conditional_string) %}
148 static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}( 148 static void {{attribute.name}}AttributeGetterCallback{{world_suffix}}(
149 {%- if attribute.is_expose_js_accessors %} 149 {%- if attribute.is_expose_js_accessors %}
150 const v8::FunctionCallbackInfo<v8::Value>& info 150 const v8::FunctionCallbackInfo<v8::Value>& info
151 {%- else %} 151 {%- else %}
152 v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info 152 v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>& info
153 {%- endif %}) 153 {%- endif %})
154 { 154 {
155 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 155 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
156 {% if attribute.deprecate_as %} 156 {% if attribute.deprecate_as %}
157 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}}); 157 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
158 {% endif %} 158 {% endif %}
159 {% if attribute.measure_as %} 159 {% if attribute.measure_as %}
160 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{attribute.measure_as('AttributeGetter')}}); 160 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{attribute.measure_as('AttributeGetter')}});
161 {% endif %} 161 {% endif %}
162 {% if world_suffix in attribute.activity_logging_world_list_for_getter %} 162 {% if world_suffix in attribute.activity_logging_world_list_for_getter %}
(...skipping 17 matching lines...) Expand all
180 {% endmacro %} 180 {% endmacro %}
181 181
182 182
183 {##############################################################################} 183 {##############################################################################}
184 {% macro constructor_getter_callback(attribute, world_suffix) %} 184 {% macro constructor_getter_callback(attribute, world_suffix) %}
185 {% filter conditional(attribute.conditional_string) %} 185 {% filter conditional(attribute.conditional_string) %}
186 static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}( 186 static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(
187 {%- if attribute.is_expose_js_accessors %} 187 {%- if attribute.is_expose_js_accessors %}
188 const v8::FunctionCallbackInfo<v8::Value>& info 188 const v8::FunctionCallbackInfo<v8::Value>& info
189 {%- else %} 189 {%- else %}
190 v8::Local<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info 190 v8::Local<v8::Name> property, const v8::PropertyCallbackInfo<v8::Value>& info
191 {%- endif %}) 191 {%- endif %})
192 { 192 {
193 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 193 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
194 {% if attribute.deprecate_as %} 194 {% if attribute.deprecate_as %}
195 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}}); 195 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
196 {% endif %} 196 {% endif %}
197 {% if attribute.measure_as %} 197 {% if attribute.measure_as %}
198 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{attribute.measure_as('ConstructorGetter')}} ); 198 UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionConte xt(info.GetIsolate()), UseCounter::{{attribute.measure_as('ConstructorGetter')}} );
199 {% endif %} 199 {% endif %}
200 {% if attribute.is_expose_js_accessors %} 200 {% if attribute.is_expose_js_accessors %}
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 {% endmacro %} 302 {% endmacro %}
303 303
304 304
305 {##############################################################################} 305 {##############################################################################}
306 {% macro attribute_setter_callback(attribute, world_suffix) %} 306 {% macro attribute_setter_callback(attribute, world_suffix) %}
307 {% filter conditional(attribute.conditional_string) %} 307 {% filter conditional(attribute.conditional_string) %}
308 static void {{attribute.name}}AttributeSetterCallback{{world_suffix}}( 308 static void {{attribute.name}}AttributeSetterCallback{{world_suffix}}(
309 {%- if attribute.is_expose_js_accessors %} 309 {%- if attribute.is_expose_js_accessors %}
310 const v8::FunctionCallbackInfo<v8::Value>& info 310 const v8::FunctionCallbackInfo<v8::Value>& info
311 {%- else %} 311 {%- else %}
312 v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI nfo<void>& info 312 v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInf o<void>& info
313 {%- endif %}) 313 {%- endif %})
314 { 314 {
315 {% if attribute.is_expose_js_accessors %} 315 {% if attribute.is_expose_js_accessors %}
316 v8::Local<v8::Value> v8Value = info[0]; 316 v8::Local<v8::Value> v8Value = info[0];
317 {% endif %} 317 {% endif %}
318 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter"); 318 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
319 {% if attribute.deprecate_as %} 319 {% if attribute.deprecate_as %}
320 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}}); 320 UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExe cutionContext(info.GetIsolate()), UseCounter::{{attribute.deprecate_as}});
321 {% endif %} 321 {% endif %}
322 {% if attribute.measure_as %} 322 {% if attribute.measure_as %}
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 access_control, 448 access_control,
449 property_attribute, 449 property_attribute,
450 only_exposed_to_private_script, 450 only_exposed_to_private_script,
451 ] %} 451 ] %}
452 {% if not attribute.is_expose_js_accessors %} 452 {% if not attribute.is_expose_js_accessors %}
453 {% set attribute_configuration_list = attribute_configuration_list 453 {% set attribute_configuration_list = attribute_configuration_list
454 + [on_prototype] %} 454 + [on_prototype] %}
455 {% endif %} 455 {% endif %}
456 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}} 456 {{'{'}}{{attribute_configuration_list | join(', ')}}{{'}'}}
457 {%- endmacro %} 457 {%- endmacro %}
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8DOMConfiguration.cpp ('k') | Source/bindings/templates/constants.cpp » ('j') | Source/bindings/templates/interface.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698