Unit Test for WebView animating in and out of screen

android_webview/browser/test/fake_window.h

Index: android_webview/browser/test/fake_window.h
diff --git a/android_webview/browser/test/fake_window.h b/android_webview/browser/test/fake_window.h
index 18b0cf4cf9661f2373864b1349b4ec0a8bc0794b..5ef2afc71be5a9ad0bf5aa3695f868e111880844 100644
--- a/android_webview/browser/test/fake_window.h
+++ b/android_webview/browser/test/fake_window.h
@@ -7,6 +7,7 @@
 
 #include <map>
 
+#include "android_webview/public/browser/draw_gl.h"
 #include "base/memory/weak_ptr.h"
 #include "base/sequence_checker.h"
 #include "base/single_thread_task_runner.h"
@@ -35,8 +36,10 @@ class WindowHooks {
   virtual void DidSyncOnRT(SharedRendererState* functor) = 0;
   virtual void WillProcessOnRT(SharedRendererState* functor) = 0;
   virtual void DidProcessOnRT(SharedRendererState* functor) = 0;
-  virtual void WillDrawOnRT(SharedRendererState* functor) = 0;
+  virtual void SetParentDrawConstraints(AwDrawGLInfo& draw_info) = 0;

[boliu, 2015/03/13 23:51:55]

I'd much rather have SetSurfaceRect, SetTransform etc on FakeWindow then have
this be callbacks.

[hush (inactive), 2015/03/16 18:19:21]

Putting it into fake window make it hard for the rendering test to override and
customize these 2 functions. RenderingTest relies on overriding WindowHooks to
customize FakeWindow behavior. 
If SetParentDrawConstraints is a function on FakeWindow, RenderingTest has no
easy way to call it at the right time, just before the DrawGL because each
DrawGL might have different transforms settable from the rendering test (unless
the specific test creates a subclass of FakeWindow).

But this will over complicate the browser_view_renderer_unittest class. What do
you think?

[boliu, 2015/03/16 20:25:08]

Merge it into WillDrawOnRT?

[hush (inactive), 2015/03/17 18:26:45]

Done.

+  virtual bool WillDrawOnRT(SharedRendererState* functor) = 0;
   virtual void DidDrawOnRT(SharedRendererState* functor) = 0;
+  virtual bool WillWaitForModeDrawToFinish() = 0;

[boliu, 2015/03/13 23:51:55]

This can be a setter too.

[hush (inactive), 2015/03/16 18:19:21]

This bool will be read by both RT and UI in the next patch. So I decide to make
it required in FakeWindow constructor. (default to false.)

[boliu, 2015/03/16 20:25:08]

Ok for now I guess.

The other option is make the instance var UI only, then just pass that bool to
FakeWindow::DrawFunctorOnRT every time.

[hush (inactive), 2015/03/17 18:26:45]

I just removed this flag..

 };
 
 class FakeWindow {
@@ -51,6 +54,7 @@ class FakeWindow {
   // BrowserViewRendererClient methods.
   void RequestDrawGL(bool wait_for_completion);
   void PostInvalidate();
+  const gfx::Size& surface_size() { return surface_size_; }
 
  private:
   class ScopedMakeCurrent;